flyte icon indicating copy to clipboard operation
flyte copied to clipboard

Add executionClusterLabel

Open RRap0so opened this issue 1 year ago • 1 comments

Tracking issue

Closes #5395

Why are the changes needed?

To add flytectlthe ability to select what execution it should go to.

What changes were proposed in this pull request?

Add a new field in the execution spec.

How was this patch tested?

With a unit test

  • [x] I updated the documentation accordingly.
  • [x] All new and existing tests passed.
  • [x] All commits are signed-off.

RRap0so avatar May 20 '24 08:05 RRap0so

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 61.11%. Comparing base (d04cf66) to head (bc3ba3e). Report is 132 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5394   +/-   ##
=======================================
  Coverage   61.10%   61.11%           
=======================================
  Files         793      793           
  Lines       51164    51169    +5     
=======================================
+ Hits        31265    31270    +5     
  Misses      17027    17027           
  Partials     2872     2872           
Flag Coverage Δ
unittests-datacatalog 69.31% <ø> (ø)
unittests-flyteadmin 58.90% <ø> (ø)
unittests-flytecopilot 17.79% <ø> (ø)
unittests-flytectl 68.34% <100.00%> (+0.02%) :arrow_up:
unittests-flyteidl 79.30% <ø> (ø)
unittests-flyteplugins 61.94% <ø> (ø)
unittests-flytepropeller 57.32% <ø> (ø)
unittests-flytestdlib 65.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 20 '24 15:05 codecov[bot]

docs failures are unrelated, the fix for that being https://github.com/flyteorg/flyte/pull/5425.

eapolinario avatar May 28 '24 23:05 eapolinario