flyte icon indicating copy to clipboard operation
flyte copied to clipboard

[flyte-core] Add tolerations and affinity for missing deployments

Open jo-gre opened this issue 1 year ago • 2 comments

Why are the changes needed?

This allows the chart to create all deployments on a tainted node. Without this, it is not possible to run the entire flyte-core chart on a node that has a taint.

What changes were proposed in this pull request?

This PR adds tolerations and affinity to the deployments flyte-pod-webhook and syncresources.

Check all the applicable boxes

  • [x] I updated the documentation accordingly.
  • [x] All new and existing tests passed.
  • [x] All commits are signed-off.

Related PRs

Docs link

jo-gre avatar May 17 '24 18:05 jo-gre

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

welcome[bot] avatar May 17 '24 18:05 welcome[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 61.07%. Comparing base (2f1f813) to head (997df11). Report is 405 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5386      +/-   ##
==========================================
- Coverage   61.08%   61.07%   -0.02%     
==========================================
  Files         793      793              
  Lines       51156    51156              
==========================================
- Hits        31251    31245       -6     
- Misses      17033    17039       +6     
  Partials     2872     2872              
Flag Coverage Δ
unittests-datacatalog 69.31% <ø> (ø)
unittests-flyteadmin 58.82% <ø> (-0.05%) :arrow_down:
unittests-flytecopilot 17.79% <ø> (ø)
unittests-flytectl 68.31% <ø> (ø)
unittests-flyteidl 79.30% <ø> (ø)
unittests-flyteplugins 61.94% <ø> (ø)
unittests-flytepropeller 57.32% <ø> (ø)
unittests-flytestdlib 65.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 15 '24 19:06 codecov[bot]