flyte icon indicating copy to clipboard operation
flyte copied to clipboard

[BUG] flyte-core helm chart missing ServiceAccounts and chart has warning messages

Open mvaalexp opened this issue 9 months ago • 3 comments

Describe the bug

flyte-core helm chart is missing some configuration functionality

  • It is missing ServiceAccounts on several Deployments
  • It has a misconfiguration in the defaults in the values.yaml causing warning messages
coalesce.go:286: warning: cannot overwrite table with non table for flyte-core.flyteagent.podEnv (map[])
  • It has naming convention inconsistencies

Expected behavior

All Deployments should have the ability to create a ServiceAccount Helm charts should not throw errors Should have the ability to overwrite the deployment names (same as other charts, e.g., flyteagent)

Additional context to reproduce

No response

Screenshots

No response

Are you sure this issue hasn't been raised already?

  • [X] Yes

Have you read the Code of Conduct?

  • [X] Yes

mvaalexp avatar May 14 '24 20:05 mvaalexp

Thank you for opening your first issue here! 🛠

welcome[bot] avatar May 14 '24 20:05 welcome[bot]

To address the issues with the flyte-core Helm chart, you can modify the values.yaml file to ensure ServiceAccounts are created for all necessary deployments and correct any misconfigurations. Here are the steps:

  1. ServiceAccounts Configuration: Ensure that each deployment has the serviceAccount section properly configured in the values.yaml file. For example, for flyteadmin:
flyteadmin:
  serviceAccount:
    create: true
    name: flyteadmin
  1. Fixing Warnings: Address the warning messages by ensuring that the values.yaml file does not have conflicting types for the same key. For example, ensure flyteagent.podEnv is correctly defined as a table if it is being overwritten.

  2. Naming Conventions: Ensure consistent naming conventions across the Helm chart by standardizing the names used in the values.yaml file and the templates.

Would you like more detailed steps or code snippets for these configurations?

Sources:


This is an AI-generated response and your feedback is appreciated! Please leave a 👍 if this is helpful and 👎 if it is not.

Mention @runllm to ask follow-up questions. See runllm.com for more!

runllm[bot] avatar May 14 '24 20:05 runllm[bot]

I have drafted proposed changes here: https://github.com/flyteorg/flyte/pull/5362

mvaalexp avatar May 14 '24 20:05 mvaalexp