flyte
flyte copied to clipboard
Grafana dashboard updates
Tracking issue
Why are the changes needed?
There are a few issues with the dashboards as is. This includes some bugs and some outdated metric names.
What changes were proposed in this pull request?
- This is a series of incremental changes I ended up making when trying to understand flyte propeller performance and debug a problem on our network.
- Add a few extra graphs/shuffle some around a bit.
- Fix some aggregation bugs e.g. missing
rate
funciton while the title says rate - Fix some axis labels.
- Correct some metrics names based on flyte-core 1.11
- Add a few descriptions.
- Probably this is still a long way from perfect but I think its probably still worth contributing.
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
- [x] I updated the documentation accordingly. Not applicable
- [x] All new and existing tests passed. Not applicable
- [x] All commits are signed-off.
Related PRs
Docs link
It looks like the CI failure is because matplotlib's website is down and breaking a docs build.
@neverett any idea why CI fails with a doc that's not changed by this PR?
I think the doc failure was caused by matplotlib's website going down. Is it still failing?
Actually that looks like a different error now
@Tom-Newton @davidmirror-ops I think you may need to merge master in to pick up changes from https://github.com/flyteorg/flyte/pull/5254 since that introduced some significant updates to the docs build
@Tom-Newton could you merge master and try again?
Sorry for being so slow. I just rebased on master
:crossed_fingers:
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 61.09%. Comparing base (
8db9901
) to head (5af4a10
). Report is 3 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #5255 +/- ##
===========================================
- Coverage 79.30% 61.09% -18.21%
===========================================
Files 18 794 +776
Lines 1295 51213 +49918
===========================================
+ Hits 1027 31289 +30262
- Misses 204 17043 +16839
- Partials 64 2881 +2817
Flag | Coverage Δ | |
---|---|---|
unittests-datacatalog | 69.31% <ø> (?) |
|
unittests-flyteadmin | 58.86% <ø> (?) |
|
unittests-flytecopilot | 17.79% <ø> (?) |
|
unittests-flytectl | 68.30% <ø> (?) |
|
unittests-flyteidl | 79.30% <ø> (ø) |
|
unittests-flyteplugins | 61.94% <ø> (?) |
|
unittests-flytepropeller | 57.32% <ø> (?) |
|
unittests-flytestdlib | 65.75% <ø> (?) |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.