flyte icon indicating copy to clipboard operation
flyte copied to clipboard

Add tests for PR #4726

Open fg91 opened this issue 1 year ago • 1 comments

Add tests for PR #4726. As a separate PR because the PR is getting too long already.

The added tests test the fixes explained in this comment.

fg91 avatar Apr 08 '24 21:04 fg91

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 61.09%. Comparing base (d409b3b) to head (9be1964).

Additional details and impacted files
@@                            Coverage Diff                             @@
##           fg91/feat/log-links-show-while-pending    #5200      +/-   ##
==========================================================================
- Coverage                                   61.11%   61.09%   -0.02%     
==========================================================================
  Files                                         793      793              
  Lines                                       51197    51197              
==========================================================================
- Hits                                        31288    31281       -7     
- Misses                                      17032    17039       +7     
  Partials                                     2877     2877              
Flag Coverage Δ
unittests-datacatalog 69.31% <ø> (ø)
unittests-flyteadmin 58.91% <ø> (-0.05%) :arrow_down:
unittests-flytecopilot 17.79% <ø> (ø)
unittests-flytectl 68.31% <ø> (ø)
unittests-flyteidl 79.30% <ø> (ø)
unittests-flyteplugins 61.94% <ø> (ø)
unittests-flytepropeller 57.32% <ø> (ø)
unittests-flytestdlib 65.73% <ø> (-0.03%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 08 '24 21:04 codecov[bot]