flyte icon indicating copy to clipboard operation
flyte copied to clipboard

fix: renaming standaloneDeployment variable to be consistent

Open TresTristesTrigues opened this issue 1 year ago • 4 comments

This PR fixes 2 issues:

  1. There was a mismatch with variable naming in the Flyte-Core chart, where standalone_deploy and standaloneDeployment were being used interchangeably
  2. cluster_resource_manager could be deployed twice as part of flyteadmin and standalone

TresTristesTrigues avatar Apr 04 '24 19:04 TresTristesTrigues

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

welcome[bot] avatar Apr 04 '24 19:04 welcome[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 59.08%. Comparing base (452538a) to head (17d1eff). Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5183      +/-   ##
==========================================
+ Coverage   59.06%   59.08%   +0.01%     
==========================================
  Files         646      646              
  Lines       55726    55739      +13     
==========================================
+ Hits        32916    32934      +18     
+ Misses      20214    20209       -5     
  Partials     2596     2596              
Flag Coverage Δ
unittests 59.08% <ø> (+0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 06 '24 05:04 codecov[bot]

cc @davidmirror-ops to review the charts

neverett avatar Apr 08 '24 14:04 neverett

@davidmirror-ops I am not sure if it should be possible to deploy it has both standalone and flyte-admin, I assume not. In that case, should this line be changed to:

{{- if and (.Values.cluster_resource_manager.enabled) (.Values.cluster_resource_manager.standaloneDeployment) }}

? (in contrast to this line)

TresTristesTrigues avatar Apr 13 '24 01:04 TresTristesTrigues