[Bug] correctly set task execution phase for terminal array node

[pvditt]

Tracking issue

https://github.com/flyteorg/flyte/issues/5135

Why are the changes needed?

Task execution phases are not set correctly for successful nor failed ArrayNodes

What changes were proposed in this pull request?

• ensure correct phase is set in task execution events

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

• [ ] I updated the documentation accordingly.
• [ ] All new and existing tests passed.
• [ ] All commits are signed-off.

Related PRs

Docs link

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 40.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 37.02%. Comparing base (b010747) to head (8e4f4fa). Report is 122 commits behind head on master.

Files with missing lines	Patch %	Lines
...ytepropeller/pkg/controller/nodes/array/handler.go	40.00%	7 Missing and 2 partials :warning:

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #5136   +/-   ##
=======================================
  Coverage   37.02%   37.02%           
=======================================
  Files        1317     1317           
  Lines      132523   132544   +21     
=======================================
+ Hits        49066    49080   +14     
- Misses      79211    79218    +7     
  Partials     4246     4246           

Flag	Coverage Δ
unittests-datacatalog	51.58% <ø> (ø)
unittests-flyteadmin	54.25% <ø> (ø)
unittests-flytecopilot	30.99% <ø> (ø)
unittests-flytectl	62.29% <ø> (ø)
unittests-flyteidl	7.23% <ø> (ø)
unittests-flyteplugins	53.85% <ø> (ø)
unittests-flytepropeller	42.66% <40.00%> (+0.02%)	:arrow_up:
unittests-flytestdlib	55.13% <ø> (-0.06%)	:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:

• :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[flyte-bot]

Code Review Agent Run #e4c107

Actionable Suggestions - 2

• flytepropeller/pkg/controller/nodes/array/handler.go - 2

  • Consider more graceful error handling · Line 132-134
  • Consider validating eventRecorder before use · Line 473-474

Review Details

• Files reviewed - 1 · Commit Range: 344bde3..6cc769f

  • flytepropeller/pkg/controller/nodes/array/handler.go
• Files skipped - 0
• Tools

  • Golangci-lint (Linter) - ✖︎ Failed
  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful

---

AI Code Review powered by

[flyte-bot]

Changelist by Bito

This pull request implements the following key changes.

Key Change	Files Impacted
Bug Fix - Fix Array Node Task Execution Phase Reporting	- handler.go - Added proper task execution phase handling for aborted and failed states - handler_test.go - Updated tests to verify correct task execution phase settings

[pvditt]

Any unit tests we should be adding? It looks like we will send some new events now right?

@hamersaw I'll upstream unit tests for array node and then add tests in this PR

[flyte-bot]

Code Review Agent Run #5e4929

Actionable Suggestions - 2

• flytepropeller/pkg/controller/nodes/array/handler_test.go - 2

  • Consider using constants for test phases · Line 220-221
  • Consider declaring err variable explicitly · Line 298-298

Review Details

• Files reviewed - 2 · Commit Range: 6cc769f..8e4f4fa

  • flytepropeller/pkg/controller/nodes/array/handler.go
  • flytepropeller/pkg/controller/nodes/array/handler_test.go
• Files skipped - 0
• Tools

  • Golangci-lint (Linter) - ✖︎ Failed
  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful

---

AI Code Review powered by

[pvditt]

@hamersaw ended up not needing to upstream tests