flyte icon indicating copy to clipboard operation
flyte copied to clipboard

[Housekeeping] Bump Go version to 1.22

Open lowc1012 opened this issue 1 year ago • 6 comments

Tracking issue

Closes #4994

Why are the changes needed?

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • [ ] I updated the documentation accordingly.
  • [ ] All new and existing tests passed.
  • [x] All commits are signed-off.

Related PRs

Docs link

lowc1012 avatar Mar 10 '24 10:03 lowc1012

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 35.82%. Comparing base (f54b74e) to head (6ae0746). Report is 164 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5032       +/-   ##
===========================================
- Coverage   61.00%   35.82%   -25.19%     
===========================================
  Files         794     1299      +505     
  Lines       51441   109297    +57856     
===========================================
+ Hits        31384    39159     +7775     
- Misses      17165    66032    +48867     
- Partials     2892     4106     +1214     
Flag Coverage Δ
unittests-datacatalog 51.37% <ø> (-17.95%) :arrow_down:
unittests-flyteadmin 53.73% <ø> (-5.01%) :arrow_down:
unittests-flytecopilot 12.17% <ø> (-5.62%) :arrow_down:
unittests-flytectl 62.63% <ø> (-5.40%) :arrow_down:
unittests-flyteidl 7.09% <ø> (-71.96%) :arrow_down:
unittests-flyteplugins 53.36% <ø> (-8.49%) :arrow_down:
unittests-flytepropeller 41.43% <ø> (-15.88%) :arrow_down:
unittests-flytestdlib 55.17% <ø> (-10.63%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 10 '24 10:03 codecov[bot]

@lowc1012 , are you still going to work on this PR? If so, can you merge master?

eapolinario avatar May 20 '24 18:05 eapolinario

@eapolinario I just came back from vacation. merged master into dev branch. thanks

lowc1012 avatar May 31 '24 12:05 lowc1012

@lowc1012 , building the sandbox is hitting a failure, can you take a look? You can reproduce locally by running make -C docker/sandbox-bundled build from the root of the repo.

eapolinario avatar Jun 12 '24 00:06 eapolinario

@eapolinario thanks, I push a new commit

lowc1012 avatar Jun 22 '24 03:06 lowc1012

Thank you, this is looking pretty good. Can you also update https://github.com/flyteorg/flyte/blob/master/boilerplate/flyte/golang_support_tools/go.mod#L3 ?

@eapolinario done

lowc1012 avatar Jun 27 '24 00:06 lowc1012