flyte icon indicating copy to clipboard operation
flyte copied to clipboard

[BUG] Invalid "resources" scope in clusterresourcesync/deployment.yaml

Open lowc1012 opened this issue 1 year ago • 2 comments

Describe the bug

https://github.com/flyteorg/flyte/blob/master/charts/flyte-core/templates/clusterresourcesync/deployment.yaml#L54

It's an invalid deployment manifest, and we have better to add default resources for this deployment in charts/flyte-core/values.yaml

Expected behavior

  1. Add resources: {} into charts/flyte-core/values.yaml as default value
  2. Use with to render resources

Additional context to reproduce

No response

Screenshots

No response

Are you sure this issue hasn't been raised already?

  • [X] Yes

Have you read the Code of Conduct?

  • [X] Yes

lowc1012 avatar Feb 17 '24 12:02 lowc1012

Thank you for opening your first issue here! 🛠

welcome[bot] avatar Feb 17 '24 12:02 welcome[bot]

🤖

Hey there, @lowc1012! 🚀 I'm Dosu, a bot here to lend a hand with bug squashing, answering your questions, and guiding you on your journey to becoming a contributor. Think of me as your digital sidekick while we wait for a human maintainer to join the fray. Just wanted to let you know I'm diving into your issue and will get back to you with a more detailed answer shortly. Stay tuned! 👾

dosubot[bot] avatar Feb 17 '24 12:02 dosubot[bot]