flyte icon indicating copy to clipboard operation
flyte copied to clipboard

Copy user guide to flyte repo

Open ppiegaze opened this issue 1 year ago • 6 comments

Copy user guide content from flytesnacks to flyte No changes to content or structure of docs website

ppiegaze avatar Feb 13 '24 08:02 ppiegaze

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (bb285d6) 58.93% compared to head (156178f) 58.92%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4887      +/-   ##
==========================================
- Coverage   58.93%   58.92%   -0.02%     
==========================================
  Files         645      645              
  Lines       55414    55414              
==========================================
- Hits        32656    32650       -6     
- Misses      20175    20181       +6     
  Partials     2583     2583              
Flag Coverage Δ
unittests 58.92% <ø> (-0.02%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 13 '24 08:02 codecov[bot]

@neverett @ppiegaze we can merge it, right?

pingsutw avatar Feb 15 '24 21:02 pingsutw

@neverett @ppiegaze we can merge it, right?

I think we should hold off merging for the moment -- the plan is for Peeter to take a pass at updating old docs links in the Flyte repo first, then we can merge this PR, then he'll update links again, since this PR will change the URL structure for some docs pages. @ppiegaze can confirm, though.

neverett avatar Feb 15 '24 21:02 neverett

gotcha, thanks

pingsutw avatar Feb 16 '24 19:02 pingsutw

Let's wait to merge this until I can add the link fixes as well. Unfortunately that will be late next week as I am off for a few days

ppiegaze avatar Feb 16 '24 19:02 ppiegaze

no rush; just let me know if there is anything I can help with.

pingsutw avatar Feb 16 '24 19:02 pingsutw

@neverett All the link updates have been done. We can merge this now, on your approval

ppiegaze avatar Feb 22 '24 14:02 ppiegaze