[House Keeping] deprecate MaxDatasetSizeBytes propeller config in favor of GetLimitMegabytes storage config

[pvditt]

…

Tracking issue

https://github.com/flyteorg/flyte/issues/

Why are the changes needed?

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

• [ ] I updated the documentation accordingly.
• [ ] All new and existing tests passed.
• [ ] All commits are signed-off.

Related PRs

Docs link

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 58.97%. Comparing base (04dc245) to head (621a1d5). Report is 2 commits behind head on master.

Files	Patch %	Lines
flytepropeller/pkg/controller/controller.go	0.00%	1 Missing :warning:

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #4852   +/-   ##
=======================================
  Coverage   58.97%   58.97%           
=======================================
  Files         645      645           
  Lines       55578    55590   +12     
=======================================
+ Hits        32778    32786    +8     
- Misses      20207    20209    +2     
- Partials     2593     2595    +2     

Flag	Coverage Δ
unittests	58.97% <50.00%> (+<0.01%)	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[pvditt]

@hamersaw yup that makes sense. I'll make a follow up PR to handle that.