flyte icon indicating copy to clipboard operation
flyte copied to clipboard

Implement GetProject endpoint in FlyteAdmin

Open RRap0so opened this issue 1 year ago • 3 comments

Tracking issue

Closes #4317

Why are the changes needed?

We have several services and operators that fetch single Project objects from flyteadmin. This new endpoint will save some filtering by only fetching the one we need instead of fetching a List of Projects (the endpoint available today)

Note: This replaces #4316 (diverged too much from main)

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • [ ] I updated the documentation accordingly.
  • [ ] All new and existing tests passed.
  • [ ] All commits are signed-off.

Related PRs

Docs link

RRap0so avatar Feb 02 '24 07:02 RRap0so

Codecov Report

Attention: Patch coverage is 53.12500% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 58.98%. Comparing base (04dc245) to head (681d2fb). Report is 2 commits behind head on master.

Files Patch % Lines
flyteadmin/pkg/rpc/adminservice/project.go 0.00% 15 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4825      +/-   ##
==========================================
+ Coverage   58.97%   58.98%   +0.01%     
==========================================
  Files         645      645              
  Lines       55578    55622      +44     
==========================================
+ Hits        32778    32811      +33     
- Misses      20207    20217      +10     
- Partials     2593     2594       +1     
Flag Coverage Δ
unittests 58.98% <53.12%> (+0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 02 '24 20:02 codecov[bot]

I've added the missing coverage for `project.go.

RRap0so avatar Feb 05 '24 12:02 RRap0so

@pingsutw added, ptal.

RRap0so avatar Feb 05 '24 19:02 RRap0so

@RRap0so Any update on this PR?

pingsutw avatar Mar 18 '24 05:03 pingsutw

@pingsutw I've done the changes and I've merged with master.

RRap0so avatar Mar 18 '24 10:03 RRap0so

@katrogan sorry about that, I've addressed all the comments.

RRap0so avatar Mar 18 '24 18:03 RRap0so

@RRap0so no problem, just wanted to make sure all changes had been pushed!

katrogan avatar Mar 18 '24 19:03 katrogan

Congrats on merging your first pull request! 🎉

welcome[bot] avatar Mar 20 '24 17:03 welcome[bot]