flyte icon indicating copy to clipboard operation
flyte copied to clipboard

New agents guide and deployment config docs updates

Open neverett opened this issue 1 year ago • 2 comments

Why are the changes needed?

To prepare for Flyte agents GA.

What changes were proposed in this pull request?

Note: Links to new agents integrations docs are broken, since those docs are in a flytesnacks branch (see https://github.com/flyteorg/flytesnacks/pull/1498).

Check all the applicable boxes

  • [ ] I updated the documentation accordingly.
  • [ ] All new and existing tests passed.
  • [x] All commits are signed-off.

Related PRs

https://github.com/flyteorg/flytesnacks/pull/1498

neverett avatar Feb 01 '24 22:02 neverett

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (6a2ce3f) 58.97% compared to head (3e05037) 58.93%. Report is 34 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4822      +/-   ##
==========================================
- Coverage   58.97%   58.93%   -0.04%     
==========================================
  Files         644      645       +1     
  Lines       55146    55380     +234     
==========================================
+ Hits        32521    32638     +117     
- Misses      20050    20159     +109     
- Partials     2575     2583       +8     
Flag Coverage Δ
unittests 58.93% <ø> (-0.04%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 01 '24 22:02 codecov[bot]

Not sure why the DCO check is failing, since all commits appear to be signed off.

neverett avatar Feb 05 '24 20:02 neverett