flyte icon indicating copy to clipboard operation
flyte copied to clipboard

[Core feature] Automate sandbox-bundled YAML Updates with Helm Charts in Makefile

Open Future-Outlier opened this issue 1 year ago • 2 comments

Motivation: Why do you think this is important?

When updating agent values in helm, it is hard for beginners to notice we need to update both helm charts in charts/flyteagent and docker/sandbox-bundled/manifests.

Goal: What should the final outcome look like, ideally?

We should combine the step generate manifest here with Makefile here.

Describe alternatives you've considered

Stay the same.

Propose: Link/Inline OR Additional context

No response

Are you sure this issue hasn't been raised already?

  • [X] Yes

Have you read the Code of Conduct?

  • [X] Yes

Future-Outlier avatar Jan 31 '24 06:01 Future-Outlier

@davidmirror-ops Can you take a look? I am not sure whether this is a good solution or not, thank you!

Future-Outlier avatar Jan 31 '24 06:01 Future-Outlier

🤖

Sure, automating the process of updating agent values in helm by combining the step to generate manifest with the Makefile is a feasible solution. This can be achieved by adding a new target in the Makefile that will handle the updating of both helm charts in charts/flyteagent and docker/sandbox-bundled/manifests.

Here is an example of how you can do it:

.PHONY: update_helm_charts
update_helm_charts: ## Update helm charts in charts/flyteagent and docker/sandbox-bundled/manifests
	bash script/update_helm_charts.sh

In the update_helm_charts.sh script, you can include the commands to update the helm charts in both directories. This way, when you run make update_helm_charts, it will automatically update the helm charts in both directories.

Please note that you will need to create the update_helm_charts.sh script and include the necessary commands to update the helm charts. The exact commands will depend on how you have set up your helm charts and what changes you need to make.

As for the current process of updating agent values in helm charts in the flyte codebase, you would need to modify the version value in the Chart.yaml file. This is done by opening the Chart.yaml file located in the charts/flyteagent directory, locating the line that starts with "version:", and changing the version number to the desired value.

The structure of the helm charts in the charts/flyteagent and docker/sandbox-bundled/manifests directories is not directly provided in the context. However, we can infer some information about the structure based on the provided YAML files. These manifests define several Kubernetes resources, including Secrets, Endpoints, Deployments, and more. Each resource is defined with a set of properties, such as apiVersion, kind, metadata, and spec.

In the context of Helm charts, these manifests would be included in the templates directory of the chart. The chart would also include a Chart.yaml file that defines the chart's metadata and a values.yaml file that provides default values for the chart's configurable parameters.

I hope this helps! If you have any further questions or need more clarification, feel free to ask.

Sources


This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.

Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.

If you want to continue the conversation, start your reply with @dosu-bot.

dosubot[bot] avatar Jan 31 '24 06:01 dosubot[bot]

#take

lowc1012 avatar Feb 23 '24 09:02 lowc1012

#take

I can help you review this PR, thank you

Future-Outlier avatar Feb 23 '24 09:02 Future-Outlier

First come first serve

Future-Outlier avatar Feb 23 '24 10:02 Future-Outlier