[BUG] Attempts are not sorted in UI
Describe the bug
The list of attempts of a task in flyteconsole are not sorted alphabetically.
Expected behavior
It would make sense to do so though as otherwise, when the number of attempts is large, it can be annoying to find a specific one.
Additional context to reproduce
Running the 1.10 release of the helm chart.
Screenshots
Are you sure this issue hasn't been raised already?
- [X] Yes
Have you read the Code of Conduct?
- [X] Yes
🤖
Hello @fg91! I'm Dosu, a bot here to help you with bugs, answer questions, and guide you through becoming a contributor while we're waiting for a human maintainer. Nice to meet you!
Thank you for bringing this to our attention. Based on the information available in the repository, it appears that the current ordering of attempts in the Flyteconsole is not based on alphabetical order but rather on the Quality of Service (QoS) specified for an execution. The QoS can be specified at different levels and the order of precedence is as follows:
- At CreateExecution request time
- In the LaunchPlan spec
- In the Workflow spec
- As an overridable MatchableResource for the underlying workflow
- Default QualityOfService specs
This order of precedence is implemented in the GetQualityOfService function. You can find more details in the flyteadmin/pkg/manager/impl/executions/quality_of_service.go file.
However, I understand that having the attempts sorted alphabetically could be beneficial for usability, especially when the number of attempts is large. Unfortunately, as a technical support rep, I don't have the ability to create pull requests or issues. I would recommend you to create a feature request for this in the Flyte repository. The Flyte maintainers are always open to suggestions that can improve the user experience.
If you have any other questions or need further clarification, feel free to ask.
Sources
"Hello 👋, this issue has been inactive for over 90 days. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will close the issue if we detect no activity in the next 7 days. Thank you for your contribution and understanding! 🙏"
"Hello 👋, this issue has been inactive for over 90 days. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will close the issue if we detect no activity in the next 7 days. Thank you for your contribution and understanding! 🙏"
Not fixed yet.
"Hello 👋, this issue has been inactive for over 90 days. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will close the issue if we detect no activity in the next 7 days. Thank you for your contribution and understanding! 🙏"
This is fixed in v2. Completely overhauled model
"Hello 👋, this issue has been inactive for over 90 days. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will close the issue if we detect no activity in the next 7 days. Thank you for your contribution and understanding! 🙏"