flyte icon indicating copy to clipboard operation
flyte copied to clipboard

move the memverge doc from deployment/plugins to deployment/agent

Open helenzhangyc opened this issue 2 years ago • 3 comments

Tracking issue

Describe your changes

Moved the MemVerge doc from deployment/plugins to deployment/agent

Check all the applicable boxes

  • [x] I updated the documentation accordingly.
  • [x] All new and existing tests passed.
  • [x] All commits are signed-off.

helenzhangyc avatar Sep 26 '23 05:09 helenzhangyc

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

welcome[bot] avatar Sep 26 '23 05:09 welcome[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 58.90%. Comparing base (8090b16) to head (2e6fb47). Report is 958 commits behind head on master.

:exclamation: Current head 2e6fb47 differs from pull request most recent head 1d4ed64

Please upload reports for the commit 1d4ed64 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4073      +/-   ##
==========================================
- Coverage   58.95%   58.90%   -0.06%     
==========================================
  Files         618      618              
  Lines       52676    52575     -101     
==========================================
- Hits        31057    30968      -89     
- Misses      19140    19142       +2     
+ Partials     2479     2465      -14     
Flag Coverage Δ
unittests 58.90% <ø> (-0.06%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 26 '23 17:09 codecov[bot]

Actually, you don't need to create a folder for memverge agent. You could just add a memverge.rst under deployment/agents image

pingsutw avatar Sep 26 '23 21:09 pingsutw

Cleaning stale PRs. Please reopen if you wan to discuss this further.

eapolinario avatar Mar 03 '25 16:03 eapolinario