flyte icon indicating copy to clipboard operation
flyte copied to clipboard

[BUG] api parity for api/v1/workflows

Open ursucarina opened this issue 2 years ago • 5 comments

Describe the bug

ListWorkflows is:

  • missing closures
  • missing filter by state functionality (similar to https://github.com/flyteorg/flyte/issues/3983)

Expected behavior

Support filter by archived state and return full closure info

Additional context to reproduce

https://hosted.cloud-staging.union.ai/api/v1/workflows/flytesnacks/development?limit=100

Screenshots

No response

Are you sure this issue hasn't been raised already?

  • [X] Yes

Have you read the Code of Conduct?

  • [X] Yes

ursucarina avatar Aug 30 '23 21:08 ursucarina

@katrogan can you help me understand this some time?

wild-endeavor avatar Sep 01 '23 17:09 wild-endeavor

@ursucarina , can you expand on why we need the closures also? The missing filter state functionality should also be fixed by the suggestion in https://github.com/flyteorg/flyte/issues/3983#issuecomment-1693741820.

eapolinario avatar Sep 08 '23 17:09 eapolinario

@eapolinario the intent is to use list workflows instead of list named_entities on the Workflows page, to reduce the number of calls we make.

ursucarina avatar Sep 21 '23 22:09 ursucarina

@wild-endeavor @eapolinario this issue is being taken up by @squiishyy

katrogan avatar Sep 21 '23 23:09 katrogan

Hello 👋, this issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will engage on it to decide if it is still applicable. Thank you for your contribution and understanding! 🙏

github-actions[bot] avatar Jun 18 '24 00:06 github-actions[bot]

Hello 👋, this issue has been inactive for over 90 days and hasn't received any updates since it was marked as stale. We'll be closing this issue for now, but if you believe this issue is still relevant, please feel free to reopen it. Thank you for your contribution and understanding! 🙏

github-actions[bot] avatar May 16 '25 00:05 github-actions[bot]