flyte icon indicating copy to clipboard operation
flyte copied to clipboard

Support filter by state in ListTasks /api/v1/tasks

Open ursucarina opened this issue 2 years ago • 2 comments

Describe the bug

Filtering by state not supported by ListTasks

Expected behavior

/api/v1/tasks/flytesnacks/development?limit=1000&sort_by.key=created_at&sort_by.direction=ASCENDING

should support filtering by state (archived), similar to how the named_entities api does it:

/api/v1/named_entities/1/flytesnacks/development?filters=eq(state,0)&token=&limit=10000&sort_by.direction=ASCENDING&sort_by.key=name

Additional context to reproduce

No response

Screenshots

No response

Are you sure this issue hasn't been raised already?

  • [X] Yes

Have you read the Code of Conduct?

  • [X] Yes

ursucarina avatar Aug 22 '23 00:08 ursucarina

The ListNamedEntities endpoint in admin changes the filters to allow for filtering by state in https://github.com/flyteorg/flyteadmin/blob/6c97bb9c5558af240b2d67290bb35393990678cb/pkg/manager/impl/named_entity_manager.go#L115-L118. That code should also be applied to ListTasks endpoint.

eapolinario avatar Aug 25 '23 18:08 eapolinario

Hello 👋, this issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will engage on it to decide if it is still applicable. Thank you for your contribution and understanding! 🙏

github-actions[bot] avatar Jun 05 '24 00:06 github-actions[bot]

Hello 👋, this issue has been inactive for over 90 days and hasn't received any updates since it was marked as stale. We'll be closing this issue for now, but if you believe this issue is still relevant, please feel free to reopen it. Thank you for your contribution and understanding! 🙏

github-actions[bot] avatar May 16 '25 00:05 github-actions[bot]