flyte icon indicating copy to clipboard operation
flyte copied to clipboard

[BUG] Log link on multi-node executions are unrendered templates

Open cosmicBboy opened this issue 10 months ago • 1 comments

Describe the bug

When requesting multiple nodes (e.g. via Elastic(nnodes=2), the Flyte UI doesn't render the log links correctly:

https://us-east-2.console.aws.amazon.com/cloudwatch/home?region=us-east-2#logsV2:log-groups/log-group/$252Faws$252Feks$252Fflyte-development$252Fworkloads/log-events/fluentbit-kube.var.log.containers.f68f625fdbdd54101a59-n1-0-worker-0_llm-fine-tuning-development_{{.containerName}}-{{.containerID}}.log

Note {{.containerName}}-{{.containerID}} at the end of the link. This is not a valid URL.

Expected behavior

The links should go to the correct logs url

Additional context to reproduce

Use any of the plugins that allow for multi-node requests, e.g. the Elastic plugin: https://docs.flyte.org/projects/flytekit/en/latest/plugins/generated/flytekitplugins.kfpytorch.Elastic.html#flytekitplugins-kfpytorch-elastic. Then request for > 1 node.

Screenshots

image

Are you sure this issue hasn't been raised already?

  • [X] Yes

Have you read the Code of Conduct?

  • [X] Yes

cosmicBboy avatar Aug 14 '23 12:08 cosmicBboy