[BUG] Validate update calls for setting task resource attributes
Describe the bug
Setting the task resource attributes for a project with {"project":"foo","domain":"development","limits":{"cpu":"4096","memory":"8Ti"}} causes flyteadmin to panic on resolving task resource attributes at create execution time
We shouldn't accept invalid configs or handle partial task resource attributes overrides gracefully
Expected behavior
Admin should not panic at create execution time for invalid or partial task resource attributes
Additional context to reproduce
No response
Screenshots
No response
Are you sure this issue hasn't been raised already?
- [X] Yes
Have you read the Code of Conduct?
- [X] Yes
Hi @katrogan, I am interested in this topic, but I am still new to flyte. Can I try this issue?
hi @hhcs9527 absolutely!
you should be able to repro this on a flyte sandbox installation by updating task resource attributes for one of the boilerplate projects (like flytesnacks) using the resources in the GH issue. Then try launching an execution and verify that it causes admin to panic
This is the code that handles reading the overriden task resource attributes: https://github.com/flyteorg/flyteadmin/blob/master/pkg/manager/impl/execution_manager.go#L531-L534 at execution time
Hello 👋, this issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will engage on it to decide if it is still applicable. Thank you for your contribution and understanding! 🙏