flyte icon indicating copy to clipboard operation
flyte copied to clipboard

[Core Feature] Add project level API to return the global settings

Open pmahindrakar-oss opened this issue 3 years ago • 5 comments

Describe the issue

With this issue https://github.com/flyteorg/flyte/issues/2070 Project domain settings have been added for execution config and which will be shown in the UI on the domain landing page.

We also need Project level global settings which the user can view

What if we do not do this?

User wont be aware of global config which can get used in the absence of project-domain settings

Related component(s)

No response

Are you sure this issue hasn't been raised already?

  • [X] Yes

Have you read the Code of Conduct?

  • [X] Yes

pmahindrakar-oss avatar Apr 05 '22 13:04 pmahindrakar-oss

hey @pmahindrakar-oss can you expand on what is a project-level global setting? do you mean the default settings at the per-domain level in the config?

katrogan avatar Apr 06 '22 17:04 katrogan

Hi @katrogan So if you check the UX here https://www.figma.com/file/s06CbgfgMMJjeDPxORhOJU/Flyte-Console we have a domain setting global which is nothing but project level default settings that get applied to all domains.

project-domain through matchable attributes provides an override for this behavior which we now have in flyteadmin. This ticket is track the project level default settings. And this would be something we want to introduce in the Project level api and subsequently have that api also return list of all domain along with their overrides

Let me know if that makes senses

pmahindrakar-oss avatar Apr 07 '22 11:04 pmahindrakar-oss

yeah thanks for clarifying, i think i got thrown off b/c the hierarchy is domain -> domain/project -> ... but I see this is just a way to expose the default/domain settings, makes sense!

katrogan avatar Apr 07 '22 16:04 katrogan

In review https://docs.google.com/document/d/1Ju74RnljISh2Hg4PD_2B5FDw8IKooVjOV1ZidAthmF0

pmahindrakar-oss avatar May 25 '22 15:05 pmahindrakar-oss

Problem statement for review : https://docs.google.com/document/d/17yP8r2BOcBAAsVOAbTPYmrIAE2BC_XGCVJ6v2fcdJzk/edit?usp=sharing

pmahindrakar-oss avatar Jun 29 '22 11:06 pmahindrakar-oss

https://github.com/flyteorg/flyteconsole/pull/689

jsonporter avatar Feb 27 '23 16:02 jsonporter