flyte icon indicating copy to clipboard operation
flyte copied to clipboard

[Core feature] Flyteadmin support for sqlite3

Open kumare3 opened this issue 2 years ago • 3 comments

Motivation: Why do you think this is important?

Currently to start sandbox flyteadmin needs a postgres server. GORM supports sqlite3 and this should be possible to use with flyteadmin

GORM support: https://gorm.io/docs/connecting_to_the_database.html#SQLite

Goal: What should the final outcome look like, ideally?

if i start flyteadmin locally, it should be possible to start with a sqlite db . This would speed up testing and starting up of flyteadmin. Similarly we can do the same for datacatalog

Describe alternatives you've considered

start a postgres server

Propose: Link/Inline OR Additional context

No response

Are you sure this issue hasn't been raised already?

  • [X] Yes

Have you read the Code of Conduct?

  • [X] Yes

kumare3 avatar Feb 06 '22 23:02 kumare3

I would be happy to work on this, will start to take a look at it.

NikeNano avatar Aug 23 '22 07:08 NikeNano

The database can be set to sqlite3 using

database:
  sqlite:
    file: admin.db

And the best way to work on this is to use the single binary development the local config is here - https://github.com/flyteorg/flyte/blob/5f801cd4f66b9a19f8321b3b420ec2a73dc6702f/flyte_local_k3d.yaml#L27-L33

And you can setup a local development environment using https://github.com/flyteorg/flyte/blob/5f801cd4f66b9a19f8321b3b420ec2a73dc6702f/Makefile#L88-L89

To modify Admin code and check it locally, I usually add a go replace https://github.com/flyteorg/flyte/blob/5f801cd4f66b9a19f8321b3b420ec2a73dc6702f/go.mod#L221

replace github.com/flyteorg/flyteadmin => ../flyteadmin

kumare3 avatar Sep 09 '22 04:09 kumare3

this is an incredibly stale PR, but this is how far we made it last time trying to get sqlite in admin working: https://github.com/flyteorg/flyteadmin/pull/374

katrogan avatar Sep 09 '22 21:09 katrogan

Hello 👋, This issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will close the issue if we detect no activity in the next 7 days. Thank you for your contribution and understanding! 🙏

github-actions[bot] avatar Aug 28 '23 00:08 github-actions[bot]

Hello 👋, This issue has been inactive for over 9 months and hasn't received any updates since it was marked as stale. We'll be closing this issue for now, but if you believe this issue is still relevant, please feel free to reopen it. Thank you for your contribution and understanding! 🙏

github-actions[bot] avatar Sep 05 '23 00:09 github-actions[bot]