scdl icon indicating copy to clipboard operation
scdl copied to clipboard

Sync Update: Simplified Removal Process

Open hunkyburrito opened this issue 2 years ago • 9 comments

Instead of trying to find the filename of each ID that needs to be removed, I decided to just remove all the files that are not in the online playlist. This should address #437 now that I don't need to guess the filename.

hunkyburrito avatar Oct 19 '22 18:10 hunkyburrito

I tested this on my 18 playlists, the error doesn't occur any more, but there is no more 'Removed {trackname}' message, which i'd still like to see. https://github.com/flyingrub/scdl/pull/438/files#diff-35e2cac53dc8ee863183c5a1405f67e69a662ea833dbb3c2428b985804aa9bd6L429

Just to know which tracks got removed

Seme4eg avatar Dec 16 '22 05:12 Seme4eg

Newest commit should print out the files it deleted once again.

I also tried to fix #441 but I haven't tested if it works yet.

hunkyburrito avatar Dec 16 '22 10:12 hunkyburrito

New error appeared Can reproduce only on your master branch

Screenshot_20230111-172626_Termux.jpg

Seme4eg avatar Jan 11 '23 14:01 Seme4eg

Should be fixed now

hunkyburrito avatar Jan 13 '23 02:01 hunkyburrito

why not merged yet? @hunkyburrito

CosmicSage avatar Feb 06 '23 16:02 CosmicSage

I don't have write access so I am waiting on it being merged as well.

hunkyburrito avatar Feb 06 '23 16:02 hunkyburrito

seems like the owner isn't interested in PRs?? @hunkyburrito

CosmicSage avatar Feb 06 '23 19:02 CosmicSage

We don't know Anyway you can install hunky's version from pip

Seme4eg avatar Feb 06 '23 22:02 Seme4eg

I was thinking of adding a feature but maybe I should stick with bash scripts given this situation.

CosmicSage avatar Feb 08 '23 16:02 CosmicSage