windows-terminal-quake icon indicating copy to clipboard operation
windows-terminal-quake copied to clipboard

[Hotkeys] "Windows" modifier is not working

Open BlueDrink9 opened this issue 4 years ago • 10 comments

My current settings under "Hotkey" are:

[
		{
			"Modifiers": "LWin",
			"Key": "OemTilde"
		},
		{
			"Modifiers": "Windows",
			"Key": "Z"
		},
		{
			"Modifiers": "Control",
			"Key": "OemTilde"
		}
	]

Using this, control+~ works, but neither win+z or win+~ work.

Version 1.1.1, Win 10 Home

BlueDrink9 avatar Feb 28 '21 23:02 BlueDrink9

@BlueDrink9 Thank you for reporting this issue! What keyboard layout are you using?

flyingpie avatar Mar 11 '21 03:03 flyingpie

Colemak. Switching to EN US (qwerty) might fix, but I currently can't start the app. Posted another issue about it.

BlueDrink9 avatar Mar 11 '21 03:03 BlueDrink9

Hmm, I redownloaded the app and re-extracted it, and this is now fixed. Sorry for wasting your time

BlueDrink9 avatar Mar 11 '21 04:03 BlueDrink9

@BlueDrink9 No worries, just happy that you took the time to report the issue!

flyingpie avatar Mar 11 '21 09:03 flyingpie

sorry for necro bumping, windows modifier still possible?

hnstcK avatar May 05 '25 14:05 hnstcK

@hnstcK Yes! Here's an example:

{
	"Apps": [
		{
			"Name": "WezTerm",
			"Hotkeys": [{ "Modifiers": "Super", "Key": "D1" }],
			// (...)
		}
	]
}

Does that work for you?

flyingpie avatar May 05 '25 22:05 flyingpie

Hey, no that's not working, running on windows with eurkey layout (https://eurkey.steffen.bruentjen.eu/start.html)

hnstcK avatar May 07 '25 21:05 hnstcK

Mm, I'm having trouble finding the issue, but I'll look into this more.

It seems that the Windows modifier has some special treatment going on, but I'm not sure how to deal with it yet.

flyingpie avatar May 07 '25 22:05 flyingpie

@hnstcK I've got a dev release where this problem should be fixed.

Could you take a look, see if it fixes the problem on your end too?

https://github.com/flyingpie/windows-terminal-quake/releases/tag/vDevSharpHook

flyingpie avatar May 14 '25 23:05 flyingpie

The "SharpHook" hotkey registration has been put behind a feature flag, as it is quite an impactful change.

{
  "Features": {
    "SharpHook": true
  }
}

Additionally, there has already been an issue with the new method, namely that bringing a window to the foreground doesn't always work properly.

This issue has also been seen with the upcoming API (to send commands to WTQ for scripting), and has to do with Windows not always allowing processes to bring a window to the foreground.

It's being worked on in this PR: https://github.com/flyingpie/windows-terminal-quake/pull/197.

flyingpie avatar Jun 14 '25 06:06 flyingpie

The new hotkey system, using SharpHook has been the new default since v2.0.16, and fully supports the "Windows" (or "Super", or "Meta") modifier.

flyingpie avatar Aug 30 '25 20:08 flyingpie