rapid icon indicating copy to clipboard operation
rapid copied to clipboard

Explicit settings support

Open flyingmutant opened this issue 3 years ago • 4 comments
trafficstars

To have an ability to customuze e.g. checks or steps per-test, without altering global environment.

Spin-off of #35.

flyingmutant avatar Aug 29 '22 18:08 flyingmutant

@flyingmutant I'm pretty interested in this as we have some tests that need tuning of the configuration (mainly to reduce the number of runs and usually have more steps in the state machine). I'd be happy to contribute this back. Do you have a design in mind (I saw your suggestion)?

mirandaconrado avatar Feb 12 '23 22:02 mirandaconrado

I think something like you've linked should be decent place to start:

  • all top-level state should move to something like var globalEnv Env
  • top-level Check will become globalEnv.Check(...).
  • WithOptions (need to decide on a good name) will construct an Env that overrides stuff in globalEnv

If you'll send a PR, I'll try my best with reviewing but can't promise very quick turnaround right now.

flyingmutant avatar Feb 13 '23 09:02 flyingmutant

+1 for this

ashishnegi avatar Mar 06 '23 21:03 ashishnegi

There is a chance that 4391f11 will mostly obviate the need to specify settings explicitly.

flyingmutant avatar May 30 '23 08:05 flyingmutant