Laravel-BugNotifier icon indicating copy to clipboard operation
Laravel-BugNotifier copied to clipboard

PATCH - Only mailables may be queued - Laravel 5.3+

Open vzool opened this issue 6 years ago • 1 comments

Description

Provide a patch to support Laravel 5.3+

Motivation and context

Why is this change required? What problem does it solve?

It does fail to send error messages in Laravel 5.4.36+ with error thrown:

InvalidArgumentException
Only mailables may be queued.

After I dig enough mailables are support from Laravel 5.3+

How has this been tested?

Please describe in detail how you tested your changes.

Include details of your testing environment, and the tests you ran to see how your change affects other areas of the code, etc.

Screenshots (if appropriate)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • [] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [x] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

Please, please, please, don't send your pull request until all of the boxes are ticked.

  • [x] I have read the CONTRIBUTING document.
  • [x] My pull request addresses exactly one patch/feature.
  • [x] I have created a branch for this patch/feature.
  • [x] Each individual commit in the pull request is meaningful.
  • [ ] I have added tests to cover my changes.
  • [x] All new and existing tests passed.
  • [x] If my change requires a change to the documentation, I have updated it accordingly.
  • [x] My code follows the code style of this project.

If you're unsure about any of these, don't hesitate to ask. We're here to help!

vzool avatar Oct 18 '17 12:10 vzool

@vzool Is this PR still in development? do you need any help?

flyingluscas avatar Oct 20 '17 02:10 flyingluscas