Richard Huang

Results 100 comments of Richard Huang

I really consider the Sitemap command in robots.txt. You can check the line 44-51 in lib/seo_checker.rb def check_robot uri = URI.parse(@url) uri.path = '/robots.txt' response = get_response(uri) if response.is_a? Net::HTTPSuccess...

I test your issue but I can't reproduce your problem. Let's confirm two things. 1. Do you use the latest seo_checker gem, the new gem version is 0.2.5 2. Do...

yes, especially some helpers are used in controllers instead of in views.

@janpaul123 could you please paste the whole method definition code? `UseScopeAccessCheck` isn't smart enough, I'd like to improve it.

@KillaPL this is probably something wrong I did in `lib/rails_best_practices/prepares/controller_prepare.rb`

@KillaPL I think I have already fixed it on master branch, please check it out and let me know if it works for you.

could you try $ cd app $ bundle exec rails_best_practices -g $ vi config/rails_best_practices.yml $ bundle exec rails_best_practices

sorry that I can't reproduce this issue. could you print custom_config https://github.com/railsbp/rails_best_practices/blob/master/lib/rails_best_practices/core/runner.rb#L42 to see if the config file exists?

you can get gem path by `bundle show rails_best_practices`, and then add debug code