Duplicator icon indicating copy to clipboard operation
Duplicator copied to clipboard

Published 20 hours ago • verified publisher icon flydev-fr

Don't require deadline for deletion of backups

Open tobisalad opened this issue 2 years ago • 3 comments

The deletion of the oldest backup when reaching the Maximum number of packages-number is only executed when the Remove backup packages older than-deadline is also set, this is not mentioned anywhere and also not desirable. This could easily be fixed by removing || empty($deadline) from line 202 of FTPClient.php and adding an empty($deadline)-check around the second half of line 225.

tobisalad avatar May 25 '22 10:05 tobisalad

@tobisalad thanks for the comment.

I can remember a discussion from 2017 with @adrianbj about this subject.

I need to check the code and the commits and I will be back to this issue. Can you confirm you are on the very last version ? Do you spotted if It happen only when using FTP mode ?

Stay tuned.

flydev-fr avatar May 25 '22 13:05 flydev-fr

It says that I'm on version v1.4.21, which I believe is the latest, I also checked in this repository and the code is the same here. It correctly deletes backups when using local storage (though not the respective log-files, which is a separate issue).

tobisalad avatar May 25 '22 13:05 tobisalad

Ok thank you. I don't remember right now why I coded this feature to only works when the setting Local Folder in ON.

I will check it and will also fix the log deletion.

flydev-fr avatar May 25 '22 14:05 flydev-fr