aircraft icon indicating copy to clipboard operation
aircraft copied to clipboard

fix(fms): remove forced turn on following leg after leg insertion

Open BlueberryKing opened this issue 6 months ago • 1 comments

Fixes #[issue_no]

Summary of Changes

Fixes a few issues with flight plan modifications:

  1. After deleting a discontinuity, it could happen that the turn of the new leg went the wrong way due to the leg constellation. This is fixes by creating a TF leg from the leg after the discontinuity.
  2. After truncating the flight plan by insertion of an existing waypoint or using DIR to, the outbound turn would sometimes go the wrong way because the following leg was coded with a forced turn. This is fixed by removing the forced turn on the following leg.

Screenshots (if necessary)

Before: image After: image

Before: image After: image

References

Additional context

Discord username (if different from GitHub):

Testing instructions

  • Fly a procedure with a forced turn, try going DIR to the leg with the forced turn (indicated by a left/right arrow in the FPLN page). Make sure the turn goes the wrong way.
  • Clear discontinuities on procedures. Make sure all turns go the right way.

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo or flybywire-aircraft-a380-842 download link at the bottom of the page

BlueberryKing avatar Aug 25 '24 10:08 BlueberryKing