feat: Improved expedited presets with quick ADIRS/APU/ENG start/stop

[frankkopp]

Summary of Changes

Improve the expedited quick Aircraft Preset loading with making ADIRS/APU/ENG starting and stopping instantly.

Major changes

• changes to ADIRS, APU, ENG, flaps/slats to allow a quick mode for very fast or instant startup and shutdown
• Improvements to the expediated mode to leverage the quick mode - e.g. new step types
• refactor the configuration to use a static XML file sitting in the aircraft package to allow future modding of presets

Additional changes:

• fixing and improving the imbalance calculation for the A32NX fadec
• Changed two wrongly named LVars (missing prefix):
  • AIRLINER_CRUISE_ALTITUDE ==> A32NX_AIRLINER_CRUISE_ALTITUDE
  • AIRLINER_TO_FLEX_TEMP ==> A32NX_AIRLINER_TO_FLEX_TEMP

Discord username (if different from GitHub): cdr_maverick

Screenshots / Video

https://github.com/flybywiresim/aircraft/assets/16833201/bcd0c3da-7f3d-4166-8057-e17cd2c1a9d5

Testing instructions

A32NX:

Test all possible combinations of presets and presets sequences. Test expedited or normal speed - even mix or change while loading Regression Test and check normal operation without using presets and ensure this has not regressed in any way.

Check:

• presets must load without hanging (hanging means the xml config is not correct)
• any intermittent error and alarms that comes up goes away after a short time without manual interaction
• no errors after a preset is loaded
• no unusual state of the aircraft after a preset is loaded - example flaps/slats not retracted/extended
• check if the state of the cockpit for each preset makes sense
  • these are roughly done along the SOP but not exactly as this wouldn't make sense
  • if you think a setting/step is incorrect in general or for a certain preset then report this - but this is not an error and does not fail QA
  • the steps are easily changed based on user and pilot feedback

Try to break it :D

Also check for regressions - there have been some changes to the ADIRS, APU, FADEC, flaps/slats code to make these instant or near-instant. So a full flight is recommended where these systems are also monitored/checked for any issues.

A380X: Same but with less priority

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

1. Make sure you are signed in to GitHub
2. Click on the Checks tab on the PR
3. On the left side, click on the bottom PR tab
4. Click on either flybywire-aircraft-a320-neo or flybywire-aircraft-a380-842 download link at the bottom of the page

[2hwk]

Could be impacted by the potential future merge freeze. https://github.com/flybywiresim/aircraft/pull/8466 may be required to be merged into this PR at some point. We're not final on this. Impact will be minor in this case.

[2hwk]

On reflection this one is closer to a tier 2 than a tier 1 test, make sure also to check normal operation without using presets and ensure this has not regressed.

[2hwk]

Quality Assurance Report

Discord : 2cas Object of testing: https://github.com/flybywiresim/aircraft/pull/8581 Tier of Testing : 2 Date : 4.05.2024

Testing Process:

A32NX:

• [ ] Test all possible combinations of presets and presets sequences.

Intermittent HOT AIR issue, able to reproduce 100% by

• Spawning in on the runway
• Instantly loading the Cold and Dark preset
• Batteries on + Power on APU

This disappears if you disable the HOT AIR, then reeanble it (following the ECAM message), but does not disappear on its own.

• [x] Test expedited or normal speed - even mix or change while loading
• [x] Regression Test and check normal operation without using presets and ensure this has not regressed in any way.

Check:

• [x] presets must load without hanging (hanging means the xml config is not correct)
• [ ] any intermittent error and alarms that comes up goes away after a short time without manual interaction
• [ ] no errors after a preset is loaded
• [x] no unusual state of the aircraft after a preset is loaded - example flaps/slats not retracted/extended
• [x] check if the state of the cockpit for each preset makes sense these are roughly done along the SOP but not exactly as this wouldn't make sense if you think a setting/step is incorrect in general or for a certain preset then report this - but this is not an error and does not fail QA the steps are easily changed based on user and pilot feedback

Try to break it :D

• [x] Also check for regressions - there have been some changes to the ADIRS, APU, FADEC, flaps/slats code to make these instant or near-instant. So a full flight is recommended where these systems are also monitored/checked for any issues.

Negatives:

• HOT AIR

Testing Results: Not Passed

Conclusions: Other than the above, works as expected

[Pruznak]

I'm quite sure this has happened to me before even on the current dev build and I also had to disable and reenable hot air.

[frankkopp]

Quality Assurance Report

Discord : 2cas Object of testing: #8581 Tier of Testing : 2 Date : 4.05.2024

This disappears if you disable the HOT AIR, then reeanble it (following the ECAM message), but does not disappear on its own.

Negatives:

• HOT AIR

@2hwk - this should be fixed due to @mjuhe's help - if possible pls retest

[2hwk]

Still observed this sometimes with the steps I listed after spawning on runway.

Also in general, The Ready for Taxi state does not seem to work (as per the video), it now waits for the APU to start up which seems like a regression.

[frankkopp]

Still observed this sometimes with the steps I listed after spawning on runway.

Also in general, The Ready for Taxi state does not seem to work (as per the video), it now waits for the APU to start up which seems like a regression.

I could not reproduce the hit air warning issue anymore.

But I found another issue when starting on runway which I don't understand yet and I have little time currently. (Somehow when starting on runway and using preset 1 the xml loaded looses a part (powered_off) - raw xml has it, the parsed data structure not. Loading preset 1 again (xml is read every time) it there and works. Can't explain the issue yet. Might be the lib I'm using idk. When I find more time I will dig into this some more.