aircraft icon indicating copy to clipboard operation
aircraft copied to clipboard

Build_Info.json not loaded within EFB because of non-reliable Aircraft Check

Open Revyn112 opened this issue 1 year ago • 0 comments

Aircraft Version

Development

Build info

{
    "built": "2024-02-14T18:56:54+00:00",
    "ref": "refs/heads/master",
    "sha": "8501776e42dda002ce1270d9516adcdfe14bd75e",
    "actor": "aguther",
    "event_name": "manual",
    "pretty_release_name": "master:8501776e",
    "version": "a32nx-v0.12.0-dev.8501776"
}

Describe the bug

The introduction of PR #8472 added a new type check for aircraft, focusing on verifying the titles of the aircraft against a list of pre-defined names. This measure was implemented to ensure consistency and accuracy in aircraft identification. However, a potential issue arises from the variability in how livery authors might title their aircraft liveries. Due to inconsistencies in naming conventions used by livery authors, there's a risk that this type check might not recognize some aircraft titles as expected. When the type check fails to identify an aircraft title correctly, it will result in the build_info.json information not being loaded. This could lead to complications, highlighting the need for a more flexible or comprehensive approach to aircraft verification.

grafik

Example of a bad livery aircraft.cfg

[VERSION]
major = 1
minor = 0

[VARIATION]
base_container = "..\FlyByWire_A320_NEO"

;===================== FLTSIM =====================

[FLTSIM.0]
title = "A32NX Lufthansa D-AIJC" ; Variation name
model = "" ; model folder
panel = "" ; panel folder
sound = "" ; sound folder

The fbw-common/src/systems/shared/src/aircraftTypeCheck.ts will search up the SimVar Title for A320 but only will find A32NX as case "other" and not loading up the build_info.json.

Expected behavior

This is exactly the expected behavior, another approach is needed to be more consistent.

Steps to reproduce

  1. Load the plane with a livery which has a "bad" title: e.g. title = "A32NX Lufthansa D-AIJC" ; Variation name
  2. Open up EFB and switch to About page in Settings.

References (optional)

No response

Additional info (optional)

Another approach could be to add a new SimVar called "A32NX_AIRCRAFT_TYPE" and to check against the value of this SimVar. Still possible to change via the Debug Tools on runtime, but this could be only a edge case.

Discord Username (optional)

Revyn112

Revyn112 avatar Feb 16 '24 05:02 Revyn112