aircraft icon indicating copy to clipboard operation
aircraft copied to clipboard

Published 20 hours ago • verified publisher icon flybywiresim

feat(acps): Rest of knobs/buttons on ACPs/RMPs, Ovhd panel and shared cockpit

Open juliansebline opened this issue 1 year ago • 12 comments

Summary of Changes

This PR makes all buttons on ACP and RMPs work and AudioSwitching knob too.

Plus, it adds an option in the EFB making the player able to choose on which side he/she is playing. This is mainly for shared cockpit purposes. By default, the option is set to "BOTH" which means each action on one ACP is performed onto the two other ones.

You have to understand the concept:

  1. "Captain" means any action on FO's ACP has no effect. If the AudioSwitching knob is rotated on Captain, ACP3 is preferred. If Rotated on F/O, no effect.
  2. "FO" means any action on Captain's ACP has no effect. If the AudioSwitching knob is rotated on F/O, ACP3 is preferred. If Rotated on Captain, no effect.

Most of the logic been rewritten to Rust. This will be useful when failures come but more importantly, the code is meant to be usable by the 380.

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub): julian_fbw

Testing instructions

COMM.txt

####### CAPTAIN SIDE: The controlling ACPs are either ACP1 or 3 (depending on AudioSwitching knob position) #######

To better spot the changes during the tests...

  • [ ] Set all knobs to 0 on CPT side
  • [ ] Set all knobs to 100 on FO side
  • [ ] Start the APU

** PLEASE KEEP IN MIND ACP3 SHOULD HAVE NO EFFECT IF AUDIO SWITCHING KNOB ON NORM.**

  • [ ] Understood

** PLEASE KEEP IN MIND CAPTAIN'S ACP SHOULD HAVE NO EFFECT IF AUDIO SWITCHING KNOB ON CAPTAIN.**

  • [ ] Understood
  1. Turn the knobs and push the buttons on Captain's ACP to different values than the other ACPs
  2. In the EFB, select Captain
    • [ ] The simvars should now be set with Captain's ACP configuration
  3. Rotate VHF1 volume knob on Captain's ACP
    • [ ] The knob of this ACP only should be rotating
    • [ ] COM VOLUME:1 simvar should update accordingly
  4. Push VHF1 knob on Captain's ACP
    • [ ] The knob of this ACP only should be changing

There's a bug in the SDK or at least unwanted behaviour

  • [ ] COM RECEIVE:1 remains at 1 if corresponding transmit button is on
  • [ ] COM RECEIVE:1 goes to 0 if transmit button is off
  1. Push VHF1 transmit button on Captain's ACP
    • [ ] The button of this ACP only should be changing
    • [ ] Simvars PILOT TRANSMITTER TYPE = 0 if on, 4 if off

There's a bug in the SDK or at unwanted behaviour

  • [ ] COM RECEIVE:1 goes to 1 if transmit button is on even if the knob is off
  • [ ] COM RECEIVE:1 goes to knob position if transmit button is off
  1. Rotate VHF2 volume knob on Captain's ACP
    • [ ] The knob of this ACP only should be rotating
    • [ ] COM VOLUME:2 simvar should update accordingly
  2. Push VHF2 knob on Captain's ACP
    • [ ] The knob of this ACP only should be changing

There's a bug in the SDK or at least unwanted behaviour

  • [ ] COM RECEIVE:2 remains at 1 if corresponding transmit button is on
  • [ ] COM RECEIVE:2 goes to 0 if transmit button is off
  1. Push VHF2 transmit button on Captain's ACP
    • [ ] The button of this ACP only should be changing
    • [ ] Simvars PILOT TRANSMITTER TYPE = 1 if on, 4 if off

There's a bug in the SDK or at unwanted behaviour

  • [ ] COM RECEIVE:2 goes to 1 if transmit button is on even if the knob is off
  • [ ] COM RECEIVE:2 goes to knob position if transmit button is off
  1. Rotate HF1, HF2, Mech, Cab and PA knob on Captain's ACP
    • [ ] The knobs of this ACP only should be changing
  2. Push HF1, HF2, Mech, Cab and PA knob on Captain's ACP
    • [ ] The knobs of this ACP only should be changing
  3. Push HF1, HF2, Mech, Cab transmit buttons on Captain's ACP (except PA)
    • [ ] The buttons of this ACP only should be changing
    • [ ] Simvar PILOT TRANSMITTER TYPE == 4
  4. Keep pressing PA transmit button with left mouse button
    • [ ] PA push button should be on on Captain's ACP only
    • [ ] Release the mouse button, the light should return to the previous selected channel
    • [ ] Simvars PILOT TRANSMITTER TYPE == 4 if on, previous channel if off
  5. On each ACP, the INTRAD switch should be set to middle position
    • [ ] Yes
  6. Left click on it
    • [ ] The switch should go to the top position on Captain's ACP only
  7. Right click on it
    • [ ] The switch should remain in this position on Captain's ACP only
  8. Left click on it
    • [ ] The switch should return to middle position on Captain's ACP only
  9. Hold Right click on it
    • [ ] The switch should go to bottom position on Captain's ACP
  10. Release the right click
    • [ ] The switch should return to middle position on Captain's ACP
  11. Rotate the AudioSwitching knob to Captain
  12. Restart at point 3 of this part but replace Captain's ACP with ACP3
    • [ ] Passed
  13. Rotate the AudioSwitching knob to FO
    • [ ] The simvars should now be set with Captain's ACP configuration
  14. Rotate the AudioSwitching knob to NORM
    • [ ] Nothing should change

####### F/O SIDE: The controlling ACPs are either ACP2 or 3 (depending on AudioSwitching knob position) #######

** PLEASE KEEP IN MIND ACP3 SHOULD HAVE NO EFFECT IF AUDIO SWITCHING KNOB ON NORM.**

  • [ ] Understood

** PLEASE KEEP IN MIND FO'S ACP SHOULD HAVE NO EFFECT IF AUDIO SWITCHING KNOB ON FO.**

  • [ ] Understood
  1. Turn the knobs and push the buttons on FO's ACP to different values than the other ACPs
  2. In the EFB, select FO
    • [ ] The simvars should now be set with FO's ACP configuration
  3. Rotate VHF1 volume knob on FO's ACP
    • [ ] The knob of this ACP only should be rotating
    • [ ] COM VOLUME:1 simvar should update accordingly
  4. Push VHF1 knob on FO's ACP
    • [ ] The knob of this ACP only should be changing
    • [ ] COM RECEIVE EX1:1 should update accordingly
  5. Push VHF1 transmit button on FO's ACP
    • [ ] The button of this ACP only should be changing
    • [ ] Simvars PILOT TRANSMITTER TYPE = 0 if on, 4 if off
  6. Rotate VHF2 volume knob on FO's ACP
    • [ ] The knob of this ACP only should be rotating
    • [ ] COM VOLUME:2 simvar should update accordingly
  7. Push VHF2 knob on FO's ACP
    • [ ] The knob of this ACP only should be changing
    • [ ] COM RECEIVE EX1:2 should update accordingly
  8. Push VHF2 transmit button on FO's ACP
    • [ ] The button of this ACP only should be changing
    • [ ] Simvars PILOT TRANSMITTER TYPE = 1 if on, 4 if off
  9. Rotate HF1, HF2, Mech, Cab and PA knob on FO's ACP
    • [ ] The knobs of this ACP only should be changing
  10. Push HF1, HF2, Mech, Cab and PA knob on FO's ACP
    • [ ] The knobs of this ACP only should be changing
  11. Push HF1, HF2, Mech, Cab transmit buttons on FO's ACP (except PA)
    • [ ] The buttons of this ACP only should be changing
    • [ ] Simvars COPILOT TRANSMITTER TYPE == 4
  12. Keep pressing PA transmit button with left mouse button
    • [ ] PA push button should be on on FO's ACP only
    • [ ] Release the mouse button, the light should return to the previous selected channel
    • [ ] Simvars PILOT TRANSMITTER TYPE == 4 if on, previous channel if off
  13. On each ACP, the INTRAD switch should be set to middle position
    • [ ] Yes
  14. Left click on it
    • [ ] The switch should go to the top position on FO's ACP only
  15. Right click on it
    • [ ] The switch should remain in this position on FO's ACP only
  16. Left click on it
    • [ ] The switch should return to middle position on FO's ACP only
  17. Hold Right click on it
    • [ ] The switch should go to bottom position on FO's ACP
  18. Release the right click
    • [ ] The switch should return to middle position on FO's ACP
  19. Rotate the AudioSwitching knob to FO
  20. Restart at point 3 of this part but replace FO's ACP with ACP3
    • [ ] Passed
  21. Rotate the AudioSwitching knob to Captain
    • [ ] The simvars should now be set with FO's ACP configuration
  22. Rotate the AudioSwitching knob to NORM
    • [ ] Nothing should change
  23. In the EFB, select BOTH
    • [ ] ALL ACPs should be updated with FO's configuration as it was the last one used

####### ELECTRICITY CHECK #######

  1. Turn off the engines
    • [ ] Only the ACPs and RMP1 should be on
  2. Press the buttons and knobs
    • [ ] Only VHF1 simvars should get updated
  3. Turn off one battery and press many buttons on the ACPs
  4. Turn on the APU
    • [ ] The facade of each ACPs should not have changed

####### MORSE CHECK #######

For this you will have to open the behaviors window and local variables tab.

  1. For each VOR knob, press it, rotate it copy 883636401 in the VOR1/2_IDENT_PACKEDLvar
    • [ ] You should be hearing multiple beeps and squelch and squelch only if the lvar is empty
    • [ ] "BRIS" is the code. "-... .-. .. ... --.-" is what you should be hearing
  2. For each ADF knob, press it, rotate itn copy 883636401 in the ADF1/2_IDENT_PACKED Lvar
    • [ ] You should be hearing multiple beeps and squelch and squelch only if the lvar is empty
    • [ ] "BRIS" is the code. "-... .-. .. ... --.-" is what you should be hearing
  3. For the ILS knob, press it, rotate it copy 883636401 in the ILS_IDENT_PACKED Lvar and press the onside LS button on the FCU
    • [ ] You should be hearing multiple beeps and squelch and squelch only if the lvar is empty
    • [ ] "BRIS" is the code. "-... .-. .. ... --.-" is what you should be hearing
  4. Check also the sides are independant like in the previous steps.

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, click on the bottom PR tab
  4. Click on the A32NX download link at the bottom of the page

juliansebline avatar Mar 13 '23 00:03 juliansebline

Quality Assurance Tester Report

Discord : Alex R#6663 Object of testing: PR #7866 Tier of Testing : 1 Date : started on 15/03/2023 ended 19/03/2023

Testing Process: Still in progress. All items until F/O have been tested. A checked items means no issues were found and it behaved as expected. If an item is unchecked, I have added a small explanation of the error after the dash.

####### BOTH SIDES #######

  1. Download the file below and rename it COMM.simvars COMM.txt
  2. Open the simvar watcher and load the file
  3. Spawn on the runway
  4. Check if the AudioSwitching knob on the overhead panel is set to NORM
  5. Turn on the EFB and go to the simulation options
    • [x] Last line (Captain, FO, Both) set to "Both" For verification: Its called cockpit seat to control - Captain/Copilot/Synchronized in the EFB
  6. Rotate VHF1 volume knob on all ACPs (including overhead)
    • [x] All related knobs should rotate and be at the same position (as the option is set to Both)
    • [x] COM VOLUME:1 simvar should update accordingly
  7. Push VHF1 knob on all ACPs (including overhead)
    • [x] All related knobs should be on/off (as the option is set to Both)
    • [x] COM RECEIVE:1 should update accordingly - Added COM RECEIVE on simvarwatcher using add request button. Added Index 0-3. Index 0 had value 0, 1-3 had value 1.
  8. Push VHF1 transmit button
    • [x] PILOT TRANSMITTER TYPE and COPILOT TRANSMITTER TYPE simvars should be set to 0 if on, 4 if off
  9. Rotate VHF2 volume knob on all ACPs (including overhead)
    • [x] All related knobs should rotate and be at the same position (as the option is set to Both)
    • [x] COM VOLUME:2 simvar should update accordingly
    • [x] PILOT TRANSMITTER TYPE and COPILOT TRANSMITTER TYPE simvars should be set to 1 if on, 4 if off
  10. Push VHF2 knob of all ACPs (including overhead)
    • [x] All related knobs should be on/off (as the option is set to Both)
    • [x] COM RECEIVE:2 should update accordingly
  11. Push VHF2 transmit button
    • [x] VHF1 transmit buttons should go off
    • [x] PILOT TRANSMITTER TYPE and COPILOT TRANSMITTER TYPE simvars should be set to 1 if on, 4 if off
  12. Rotate HF1, HF2, Mech, Cab and PA knob on all ACPs (including overhead)
    • [x] All related knobs should rotate and be at the same position (as the option is set to Both)
  13. Push HF1, HF2, Mech, Cab and PA knob on all ACPs (including overhead)
    • [x] All knobs should be on/off (as the option is set to Both)
  14. Push HF1, HF2, Mech, Cab transmit buttons on all ACPs (except PA)
    • [x] All buttons should be on/off (as the option is set to Both)
    • [x] Only one transmit button can be on at a time
  15. Keep pressing PA transmit button with left mouse button
    • [x] Only PA push button should be on on all ACPs
    • [x] Release the mouse button, the light should return to the previous selected channel
  16. On each ACP, the INTRAD switch should be set to middle position
    • [x] Yes
  17. Left click on it
    • [x] The switch should go to the top position on all ACPs
  18. Right click on it
    • [x] The switch should remain in this position on all ACPs
  19. Left click on it
    • [x] The switch should return to middle position on all ACPs
  20. Hold Right click on it
    • [x] The switch should go to bottom position on all ACPs
    • [x] Lvar IS_EMITTING_ON_FREQUENCY should be set to 1
  21. Release the right click
    • [x] The switch should return to middle position on all ACPs
    • [x] Lvar IS_EMITTING_ON_FREQUENCY should be set to 0

####### CAPTAIN SIDE: The controlling ACPs are either ACP1 or 3 (depending on AudioSwitching knob position) #######

** PLEASE KEEP IN MIND ACP3 SHOULD HAVE NO EFFECT IF AUDIO SWITCHING KNOB ON NORM.**

  • [x] Understood

** PLEASE KEEP IN MIND CAPTAIN'S ACP SHOULD HAVE NO EFFECT IF AUDIO SWITCHING KNOB ON CAPTAIN.**

  • [x] Understood
  1. Turn the knobs and push the buttons on Captain's ACP to different values than the other ACPs -Not possible as long as EFB was set to both. Setting FB to captain. I am now able set to different values as other ACP.
  2. In the EFB, select Captain
    • [x] The simvars should now be set with Captain's ACP configuration - Side note: Turning VHF3 knob has no effect on COM VOLUME:3. Neither in captain nor in synchronized and is always 1.
  3. Rotate VHF1 volume knob on Captain's ACP
    • [x] The knob of this ACP only should be rotating
    • [x] COM VOLUME:1 simvar should update accordingly
  4. Push VHF1 knob on Captain's ACP
    • [x] The knob of this ACP only should be changing
    • [x] COM RECEIVE:1 should update accordingly - Value is always 1 when vhf1 transmit is on. If transmit is off (pilot type = 4) then it updates correctly.
  5. Push VHF1 transmit button on Captain's ACP
    • [x] The button of this ACP only should be changing
    • [x] Simvars PILOT TRANSMITTER TYPE = 0 if on, 4 if off and COPILOT TRANSMITTER TYPE = 4
  6. Rotate VHF2 volume knob on Captain's ACP
    • [x] The knob of this ACP only should be rotating
    • [x] COM VOLUME:2 simvar should update accordingly
  7. Push VHF2 knob on Captain's ACP
    • [x] The knob of this ACP only should be changing
    • [x] COM RECEIVE:2 should update accordingly
  8. Push VHF2 transmit button on Captain's ACP
    • [x] The button of this ACP only should be changing
    • [x] Simvars PILOT TRANSMITTER TYPE = 1 if on, 4 if off and COPILOT TRANSMITTER TYPE = 4
  9. Rotate HF1, HF2, Mech, Cab and PA knob on Captain's ACP
    • [x] The knobs of this ACP only should be changing
  10. Push HF1, HF2, Mech, Cab and PA knob on Captain's ACP
    • [x] The knobs of this ACP only should be changing
  11. Push HF1, HF2, Mech, Cab transmit buttons on Captain's ACP (except PA)
    • [x] The buttons of this ACP only should be changing
  12. Keep pressing PA transmit button with left mouse button
    • [x] PA push button should be on on Captain's ACP only
    • [x] Release the mouse button, the light should return to the previous selected channel
    • [x] Simvars PILOT TRANSMITTER TYPE = 8 if on, previous channel if off and COPILOT TRANSMITTER TYPE = 4
  13. On each ACP, the INTRAD switch should be set to middle position
    • [x] Yes
  14. Left click on it
    • [x] The switch should go to the top position on Captain's ACP only
    • [x] Simvars PILOT TRANSMITTER TYPE = 6 and COPILOT TRANSMITTER TYPE = 4
  15. Right click on it
    • [x] The switch should remain in this position on Captain's ACP only
  16. Left click on it
    • [x] The switch should return to middle position on Captain's ACP only
    • [x] Simvars PILOT TRANSMITTER TYPE = current transmit channel and COPILOT TRANSMITTER TYPE = 4
  17. Hold Right click on it
    • [x] The switch should go to bottom position on Captain's ACP
    • [x] Lvar IS_EMITTING_ON_FREQUENCY should be set to 1
  18. Release the right click
    • [x] The switch should return to middle position on Captain's ACP
    • [x] Lvar IS_EMITTING_ON_FREQUENCY should be set to 0
  19. Rotate the AudioSwitching knob to Captain
  20. Restart at point 3 of this part but replace Captain's ACP with ACP3
    • [x] Passed - Same behaviour and same issues as with acp1.
  21. Rotate the AudioSwitching knob to FO
    • [x] The simvars should now be set with Captain's ACP configuration
  22. Rotate the AudioSwitching knob to NORM
    • [x] Nothing should change

####### F/O SIDE: The controlling ACPs are either ACP2 or 3 (depending on AudioSwitching knob position) #######

** PLEASE KEEP IN MIND ACP3 SHOULD HAVE NO EFFECT IF AUDIO SWITCHING KNOB ON NORM.**

  • [x] Understood

** PLEASE KEEP IN MIND FO'S ACP SHOULD HAVE NO EFFECT IF AUDIO SWITCHING KNOB ON FO.**

  • [x] Understood
  1. Turn the knobs and push the buttons on FO's ACP to different values than the other ACPs
  2. In the EFB, select FO
    • [x] The simvars should now be set with FO's ACP configuration
  3. Rotate VHF1 volume knob on FO's ACP
    • [x] The knob of this ACP only should be rotating
    • [x] COM VOLUME:1 simvar should update accordingly
  4. Push VHF1 knob on FO's ACP
    • [x] The knob of this ACP only should be changing
    • [x] COM RECEIVE:1 should update accordingly - com receive only updates from 0 to 1 if vhf1 call button is not illuminated. If call button is illuminated, COM RECEIVE:1 is always 1
  5. Push VHF1 transmit button on FO's ACP
    • [x] The button of this ACP only should be changing
    • [x] Simvars COPILOT TRANSMITTER TYPE = 0 if on, 4 if off and PILOT TRANSMITTER TYPE = 4
  6. Rotate VHF2 volume knob on FO's ACP
    • [x] The knob of this ACP only should be rotating
    • [x] COM VOLUME:2 simvar should update accordingly
  7. Push VHF2 knob on FO's ACP
    • [x] The knob of this ACP only should be changing
    • [x] COM RECEIVE:2 should update accordingly
  8. Push VHF2 transmit button on FO's ACP
    • [x] The button of this ACP only should be changing
    • [x] Simvars COPILOT TRANSMITTER TYPE = 1 if on, 4 if off and PILOT TRANSMITTER TYPE = 4
  9. Rotate HF1, HF2, Mech, Cab and PA knob on FO's ACP
    • [x] The knobs of this ACP only should be changing
  10. Push HF1, HF2, Mech, Cab and PA knob on FO's ACP
    • [x] The knobs of this ACP only should be changing
  11. Push HF1, HF2, Mech, Cab transmit buttons on FO's ACP (except PA)
    • [x] The buttons of this ACP only should be changing
  12. Keep pressing PA transmit button with left mouse button
    • [x] PA push button should be on on FO's ACP only
    • [x] Release the mouse button, the light should return to the previous selected channel
    • [x] Simvars COPILOT TRANSMITTER TYPE = 8 if on, previous channel if off and PILOT TRANSMITTER TYPE = 4
  13. On each ACP, the INTRAD switch should be set to middle position
    • [x] Yes
  14. Left click on it
    • [x] The switch should go to the top position on FO's ACP only
    • [x] Simvars COPILOT TRANSMITTER TYPE = 6 and PILOT TRANSMITTER TYPE = 4
  15. Right click on it
    • [x] The switch should remain in this position on FO's ACP only
  16. Left click on it
    • [x] The switch should return to middle position on FO's ACP only
    • [x] Simvars COPILOT TRANSMITTER TYPE = current transmit channel and PILOT TRANSMITTER TYPE = 4
  17. Hold Right click on it
    • [x] The switch should go to bottom position on FO's ACP
    • [x] Lvar IS_EMITTING_ON_FREQUENCY should be set to 1
  18. Release the right click
    • [x] The switch should return to middle position on FO's ACP
    • [x] Lvar IS_EMITTING_ON_FREQUENCY should be set to 0
  19. Rotate the AudioSwitching knob to FO
  20. Restart at point 3 of this part but replace FO's ACP with ACP3
    • [x] Passed - ACP3 had same issue as ACP2
  21. Rotate the AudioSwitching knob to Captain
    • [x] The simvars should now be set with FO's ACP configuration
  22. Rotate the AudioSwitching knob to NORM
    • [x] Nothing should change
  23. In the EFB, select BOTH
    • [x] ALL ACPs should be updated with FO's configuration as it was the last one used

Negatives:
N/A

Testing Results: Passed

Conclusions: Everything works as expected.

alexr4339 avatar Mar 15 '23 13:03 alexr4339

Fix merge conflicts ^^

2hwk avatar Mar 30 '23 15:03 2hwk

Fix merge conflicts ^^

Wilco once at home this weekend

juliansebline avatar Mar 30 '23 15:03 juliansebline

QA Report

Discord: alepouna Object of testing: #7866 Tier of Testing : 1 Date : 25/6/2023

Testing Process:

####### BOTH SIDES #######

  1. Download the file below and rename it COMM.simvars COMM.txt

  2. Open the simvar watcher and load the file

  3. Spawn on the runway

  4. Check if the AudioSwitching knob on the overhead panel is set to NORM

  5. Turn on the EFB and go to the simulation options

    • [X] Last line (Captain, FO, Both) set to "Both"

  6. Rotate VHF1 volume knob on all ACPs (including overhead)

    • [X] All related knobs should rotate and be at the same position (as the option is set to Both)
    • [X] COM VOLUME:1 simvar should update accordingly

  7. Push VHF1 knob on all ACPs (including overhead)

    • [X] All related knobs should be on/off (as the option is set to Both)
    • [X] COM RECEIVE:1 should update accordingly

  8. Push VHF1 transmit button

    • [X] PILOT TRANSMITTER TYPE and COPILOT TRANSMITTER TYPE simvars should be set to 0 if on, 4 if off

  9. Rotate VHF2 volume knob on all ACPs (including overhead)

    • [X] All related knobs should rotate and be at the same position (as the option is set to Both)
    • [X] COM VOLUME:2 simvar should update accordingly
    • [X] PILOT TRANSMITTER TYPE and COPILOT TRANSMITTER TYPE simvars should be set to 1 if on, 4 if off

  10. Push VHF2 knob of all ACPs (including overhead)

    • [X] All related knobs should be on/off (as the option is set to Both)
    • [X] COM RECEIVE:2 should update accordingly

  11. Push VHF2 transmit button

    • [X] VHF1 transmit buttons should go off
    • [X] PILOT TRANSMITTER TYPE and COPILOT TRANSMITTER TYPE simvars should be set to 1 if on, 4 if off

  12. Rotate HF1, HF2, Mech, Cab and PA knob on all ACPs (including overhead)

    • [X] All related knobs should rotate and be at the same position (as the option is set to Both)

  13. Push HF1, HF2, Mech, Cab and PA knob on all ACPs (including overhead)

    • [X] All knobs should be on/off (as the option is set to Both)

  14. Push HF1, HF2, Mech, Cab transmit buttons on all ACPs (except PA)

    • [X] All buttons should be on/off (as the option is set to Both)
    • [X] Only one transmit button can be on at a time

  15. Keep pressing PA transmit button with left mouse button

    • [X] Only PA push button should be on on all ACPs
    • [X] Release the mouse button, the light should return to the previous selected channel

  16. On each ACP, the INTRAD switch should be set to middle position

    • [X] Yes

  17. Left click on it

    • [X] The switch should go to the top position on all ACPs

  18. Right click on it

    • [X] The switch should remain in this position on all ACPs

  19. Left click on it

    • [X] The switch should return to middle position on all ACPs

  20. Hold Right click on it

    • [NOT PASSED - LEGACY CONTROLS INOP | OP for other control method] The switch should go to bottom position on all ACPs
    • [ref above] Lvar IS_EMITTING_ON_FREQUENCY simvar should be set to 1

  21. Release the right click

    • [ref 20] The switch should return to middle position on all ACPs
    • [ref 20] Lvar IS_EMITTING_ON_FREQUENCY simvar should be set to 0

####### CAPTAIN SIDE: The controlling ACPs are either ACP1 or 3 (depending on AudioSwitching knob position) #######

** PLEASE KEEP IN MIND ACP3 SHOULD HAVE NO EFFECT IF AUDIO SWITCHING KNOB ON NORM.**

  • [X] Understood

** PLEASE KEEP IN MIND CAPTAIN'S ACP SHOULD HAVE NO EFFECT IF AUDIO SWITCHING KNOB ON CAPTAIN.**

  • [X] Understood
  1. Turn the knobs and push the buttons on Captain's ACP to different values than the other ACPs
  2. In the EFB, select Captain
    • [X] The simvars should now be set with Captain's ACP configuration
  3. Rotate VHF1 volume knob on Captain's ACP
    • [X] The knob of this ACP only should be rotating
    • [X] COM VOLUME:1 simvar should update accordingly
  4. Push VHF1 knob on Captain's ACP
    • [X] The knob of this ACP only should be changing
    • [X] COM RECEIVE:1 should update accordingly
  5. Push VHF1 transmit button on Captain's ACP
    • [X] The button of this ACP only should be changing
    • [X] Simvars PILOT TRANSMITTER TYPE = 0 if on, 4 if off and COPILOT TRANSMITTER TYPE = 4
  6. Rotate VHF2 volume knob on Captain's ACP
    • [X] The knob of this ACP only should be rotating
    • [X] COM VOLUME:2 simvar should update accordingly
  7. Push VHF2 knob on Captain's ACP
    • [X] The knob of this ACP only should be changing
    • [X] COM RECEIVE:2 should update accordingly
  8. Push VHF2 transmit button on Captain's ACP
    • [X] The button of this ACP only should be changing
    • [X] Simvars PILOT TRANSMITTER TYPE = 1 if on, 4 if off and COPILOT TRANSMITTER TYPE = 4
  9. Rotate HF1, HF2, Mech, Cab and PA knob on Captain's ACP
    • [X] The knobs of this ACP only should be changing
  10. Push HF1, HF2, Mech, Cab and PA knob on Captain's ACP
    • [X] The knobs of this ACP only should be changing
  11. Push HF1, HF2, Mech, Cab transmit buttons on Captain's ACP (except PA)
    • [X] The buttons of this ACP only should be changing
  12. Keep pressing PA transmit button with left mouse button
    • [X] PA push button should be on on Captain's ACP only
    • [X] Release the mouse button, the light should return to the previous selected channel
    • [X] Simvars PILOT TRANSMITTER TYPE = 8 if on, previous channel if off and COPILOT TRANSMITTER TYPE = 4
  13. On each ACP, the INTRAD switch should be set to middle position
    • [X] Yes
  14. Left click on it
    • [X] The switch should go to the top position on Captain's ACP only
    • [X] Simvars PILOT TRANSMITTER TYPE = 6 and COPILOT TRANSMITTER TYPE = 4
  15. Right click on it
    • [ref 20 from first set] The switch should remain in this position on Captain's ACP only
  16. Left click on it
    • [X] The switch should return to middle position on Captain's ACP only
    • [X] Simvars PILOT TRANSMITTER TYPE = current transmit channel and COPILOT TRANSMITTER TYPE = 4
  17. Hold Right click on it
    • [ref 20 from first set] The switch should go to bottom position on Captain's ACP
    • [ref 20 from first set] Lvar IS_EMITTING_ON_FREQUENCY should be set to 1
  18. Release the right click
    • [ref 20 from first set] The switch should return to middle position on Captain's ACP
    • [ref 20 from first set] Lvar IS_EMITTING_ON_FREQUENCY should be set to 0
  19. Rotate the AudioSwitching knob to Captain
  20. Restart at point 3 of this part but replace Captain's ACP with ACP3
    • [X] Passed
  21. Rotate the AudioSwitching knob to FO
    • [X] The simvars should now be set with Captain's ACP configuration
  22. Rotate the AudioSwitching knob to NORM
    • [X] Nothing should change

####### F/O SIDE: The controlling ACPs are either ACP2 or 3 (depending on AudioSwitching knob position) #######

** PLEASE KEEP IN MIND ACP3 SHOULD HAVE NO EFFECT IF AUDIO SWITCHING KNOB ON NORM.**

  • [X] Understood

** PLEASE KEEP IN MIND FO'S ACP SHOULD HAVE NO EFFECT IF AUDIO SWITCHING KNOB ON FO.**

  • [X] Understood
  1. Turn the knobs and push the buttons on FO's ACP to different values than the other ACPs
  2. In the EFB, select FO
    • [X] The simvars should now be set with FO's ACP configuration
  3. Rotate VHF1 volume knob on FO's ACP
    • [X] The knob of this ACP only should be rotating
    • [X] COM VOLUME:1 simvar should update accordingly
  4. Push VHF1 knob on FO's ACP
    • [X] The knob of this ACP only should be changing
    • [X] COM RECEIVE:1 should update accordingly
  5. Push VHF1 transmit button on FO's ACP
    • [X] The button of this ACP only should be changing
    • [X] Simvars PILOT TRANSMITTER TYPE = 0 if on, 4 if off and COPILOT TRANSMITTER TYPE = 4
  6. Rotate VHF2 volume knob on FO's ACP
    • [X] The knob of this ACP only should be rotating
    • [X] COM VOLUME:2 simvar should update accordingly
  7. Push VHF2 knob on FO's ACP
    • [X] The knob of this ACP only should be changing
    • [X] COM RECEIVE:2 should update accordingly
  8. Push VHF2 transmit button on FO's ACP
    • [X] The button of this ACP only should be changing
    • [X] Simvars COPILOT TRANSMITTER TYPE = 1 if on, 4 if off and PILOT TRANSMITTER TYPE = 4
  9. Rotate HF1, HF2, Mech, Cab and PA knob on FO's ACP
    • [X] The knobs of this ACP only should be changing
  10. Push HF1, HF2, Mech, Cab and PA knob on FO's ACP
    • [X] The knobs of this ACP only should be changing
  11. Push HF1, HF2, Mech, Cab transmit buttons on FO's ACP (except PA)
    • [X] The buttons of this ACP only should be changing
  12. Keep pressing PA transmit button with left mouse button
    • [X] PA push button should be on on FO's ACP only
    • [X] Release the mouse button, the light should return to the previous selected channel
    • [X] Simvars COPILOT TRANSMITTER TYPE = 8 if on, previous channel if off and PILOT TRANSMITTER TYPE = 4
  13. On each ACP, the INTRAD switch should be set to middle position
    • [X] Yes
  14. Left click on it
    • [X] The switch should go to the top position on FO's ACP only
    • [X] Simvars COPILOT TRANSMITTER TYPE = 6 and PILOT TRANSMITTER TYPE = 4
  15. Right click on it
    • [ref 20 first set] The switch should remain in this position on FO's ACP only
  16. Left click on it
    • [ref 20 first set] The switch should return to middle position on FO's ACP only
    • [ref 20 first set] Simvars COPILOT TRANSMITTER TYPE = current transmit channel and PILOT TRANSMITTER TYPE = 4
  17. Hold Right click on it
    • [ref 20 first set] The switch should go to bottom position on FO's ACP
    • [ref 20 first set] Lvar IS_EMITTING_ON_FREQUENCY should be set to 1
  18. Release the right click
    • [ref 20 first set] The switch should return to middle position on FO's ACP
    • [ref 20 first set] Lvar IS_EMITTING_ON_FREQUENCY should be set to 0
  19. Rotate the AudioSwitching knob to FO
  20. Restart at point 3 of this part but replace FO's ACP with ACP3
    • [Not passed COPILOT TRANSMIT TYPE DOES NOT CHANGE] Passed
  21. Rotate the AudioSwitching knob to Captain
    • [X] The simvars should now be set with FO's ACP configuration
  22. Rotate the AudioSwitching knob to NORM
    • [X] Nothing should change
  23. In the EFB, select BOTH
    • [Only after changing one value - not really a negative] ALL ACPs should be updated with FO's configuration as it was the last one used

Notes: The rotation speed for VHF 1 and 2 is fast, but for everything else (VHF 3, HF1, HF 2, INT, CAB, PA, VOR 1, VOR 2, MKR, ILS, MLS, ADF1, ADF2) is slower

Negatives:

  1. Refer set 1 test 20: INTRAD is not able to moved to the bottom position in legacy controls, works fine on normal mode or if right click is used but not with normal controls
  2. Refer set 3 test 23: Once Cockpit seat used to control BOTH ACPs, the values will sync AFTER at least either ACP(including 3) have a change of values, they do not change to what the captain has set when pressing the button on the EFB.

Testing Results: Passed with remarks

alepouna avatar Jul 15 '23 17:07 alepouna

I've had a quick scan over.

Thanks a lot! I'll fix all this very soon.

juliansebline avatar Jul 25 '23 10:07 juliansebline

@tracernz Anything that is still missing/needs another check from your side?

beheh avatar Sep 14 '23 09:09 beheh

QA Report

Discord: alepouna Object of testing: #7866 Tier of Testing : 1 Date : 25/6/2023

Testing Results:

Not Passed

Notes:

Because github does not add spaces, I have added dividers for each section of the negative report.

Negatives:

Push VHF1 knob on Captain's ACP The knob of this ACP only should be changing COM RECEIVE:1 should update accordingly

If the CALL button is LIT then VHF1 RECEIVE does not change based on the knob position . If the CALL button is NOT LIT then VHF1 RECEIVE changes based on the knob position.

ACP3 is INOP. INT/RAD switches move, rotation and push moves, CALL buttons do not work.

Rotate the AudioSwitching knob to Captain Restart at point 3 of this part but replace Captain's ACP with ACP3

ACP3 does not change anything in CAPTAIN config, most simvars go to 0.

Rotate the AudioSwitching knob to FO The simvars should now be set with Captain's ACP configuration

ACP3 does not change anything in FO config either, most simvars go to 0.

Electrical Test:

Only VHF1 simvars should get updated

All simvars updated.

Morse Test:

For each VOR knob, press it, rotate it copy 883636401 in the NAV1/2_IDENT_PACKEDLvar

The vars menu changed the variable from 883636401 to 883636416 when pressing enter. Only squelching was heard. Note: The squelch seems to be a very very short audio loop and sounds pretty repetitive after 5-6 seconds.

Testing Process:

Download this file and change the extension for ".simvars".

####### CAPTAIN SIDE: The controlling ACPs are either ACP1 or 3 (depending on AudioSwitching knob position) #######

To better spot the changes during the tests...

Set all knobs to 0 on CPT side Set all knobs to 100 on FO side Start the APU ** PLEASE KEEP IN MIND ACP3 SHOULD HAVE NO EFFECT IF AUDIO SWITCHING KNOB ON NORM.**

Understood ** PLEASE KEEP IN MIND CAPTAIN'S ACP SHOULD HAVE NO EFFECT IF AUDIO SWITCHING KNOB ON CAPTAIN.**

Understood Turn the knobs and push the buttons on Captain's ACP to different values than the other ACPs In the EFB, select Captain The simvars should now be set with Captain's ACP configuration Rotate VHF1 volume knob on Captain's ACP The knob of this ACP only should be rotating COM VOLUME:1 simvar should update accordingly Push VHF1 knob on Captain's ACP The knob of this ACP only should be changing COM RECEIVE:1 should update accordingly Push VHF1 transmit button on Captain's ACP The button of this ACP only should be changing Simvars PILOT TRANSMITTER TYPE = 0 if on, 4 if off and COPILOT TRANSMITTER TYPE = 4 Rotate VHF2 volume knob on Captain's ACP The knob of this ACP only should be rotating COM VOLUME:2 simvar should update accordingly Push VHF2 knob on Captain's ACP The knob of this ACP only should be changing COM RECEIVE:2 should update accordingly Push VHF2 transmit button on Captain's ACP The button of this ACP only should be changing Simvars PILOT TRANSMITTER TYPE = 1 if on, 4 if off and COPILOT TRANSMITTER TYPE = 4 Rotate HF1, HF2, Mech, Cab and PA knob on Captain's ACP The knobs of this ACP only should be changing Push HF1, HF2, Mech, Cab and PA knob on Captain's ACP The knobs of this ACP only should be changing Push HF1, HF2, Mech, Cab transmit buttons on Captain's ACP (except PA) The buttons of this ACP only should be changing Simvar PILOT TRANSMITTER TYPE should be equal to 4 Keep pressing PA transmit button with left mouse button PA push button should be on on Captain's ACP only Release the mouse button, the light should return to the previous selected channel Simvars PILOT TRANSMITTER TYPE = 4 if on, previous channel if off and COPILOT TRANSMITTER TYPE = 4 On each ACP, the INTRAD switch should be set to middle position Yes Left click on it The switch should go to the top position on Captain's ACP only Right click on it The switch should remain in this position on Captain's ACP only Left click on it The switch should return to middle position on Captain's ACP only Hold Right click on it The switch should go to bottom position on Captain's ACP Release the right click The switch should return to middle position on Captain's ACP Rotate the AudioSwitching knob to Captain Restart at point 3 of this part but replace Captain's ACP with ACP3 Passed Rotate the AudioSwitching knob to FO The simvars should now be set with Captain's ACP configuration Rotate the AudioSwitching knob to NORM Nothing should change ####### F/O SIDE: The controlling ACPs are either ACP2 or 3 (depending on AudioSwitching knob position) #######

** PLEASE KEEP IN MIND ACP3 SHOULD HAVE NO EFFECT IF AUDIO SWITCHING KNOB ON NORM.**

Understood ** PLEASE KEEP IN MIND FO'S ACP SHOULD HAVE NO EFFECT IF AUDIO SWITCHING KNOB ON FO.**

Understood Turn the knobs and push the buttons on FO's ACP to different values than the other ACPs In the EFB, select FO The simvars should now be set with FO's ACP configuration Rotate VHF1 volume knob on FO's ACP The knob of this ACP only should be rotating COM VOLUME:1 simvar should update accordingly Push VHF1 knob on FO's ACP The knob of this ACP only should be changing COM RECEIVE:1 should update accordingly Push VHF1 transmit button on FO's ACP The button of this ACP only should be changing Simvars PILOT TRANSMITTER TYPE = 0 if on, 4 if off and COPILOT TRANSMITTER TYPE = 4 Rotate VHF2 volume knob on FO's ACP The knob of this ACP only should be rotating COM VOLUME:2 simvar should update accordingly Push VHF2 knob on FO's ACP The knob of this ACP only should be changing COM RECEIVE:2 should update accordingly Push VHF2 transmit button on FO's ACP The button of this ACP only should be changing Simvars COPILOT TRANSMITTER TYPE = 1 if on, 4 if off and PILOT TRANSMITTER TYPE = 4 Rotate HF1, HF2, Mech, Cab and PA knob on FO's ACP The knobs of this ACP only should be changing Push HF1, HF2, Mech, Cab and PA knob on FO's ACP The knobs of this ACP only should be changing Push HF1, HF2, Mech, Cab transmit buttons on FO's ACP (except PA) The buttons of this ACP only should be changing Simvars COPILOT TRANSMITTER TYPE = 6 Keep pressing PA transmit button with left mouse button PA push button should be on on FO's ACP only Release the mouse button, the light should return to the previous selected channel Simvars COPILOT TRANSMITTER TYPE = 6 if on, previous channel if off and PILOT TRANSMITTER TYPE = 4 On each ACP, the INTRAD switch should be set to middle position Yes Left click on it The switch should go to the top position on FO's ACP only Right click on it The switch should remain in this position on FO's ACP only Left click on it The switch should return to middle position on FO's ACP only Hold Right click on it The switch should go to bottom position on FO's ACP Release the right click The switch should return to middle position on FO's ACP Rotate the AudioSwitching knob to FO Restart at point 3 of this part but replace FO's ACP with ACP3 Passed Rotate the AudioSwitching knob to Captain The simvars should now be set with FO's ACP configuration Rotate the AudioSwitching knob to NORM Nothing should change In the EFB, select BOTH ALL ACPs should be updated with FO's configuration as it was the last one used ####### ELECTRICITY CHECK #######

Turn off the engines Only the ACPs and RMP1 should be on Press the buttons and knobs Only VHF1 simvars should get updated Turn off one battery and press many buttons on the ACPs Turn on the APU The facade of each ACPs should not have changed ####### MORSE CHECK #######

For this you will have to open the behaviors window and local variables tab.

For each VOR knob, press it, rotate it copy 883636401 in the NAV1/2_IDENT_PACKEDLvar You should be hearing multiple beeps and squelch and squelch only if the lvar is empty For each ADF knob, press it, rotate itn copy 883636401 in the ADF1/2_IDENT_PACKED Lvar You should be hearing multiple beeps and squelch and squelch only if the lvar is empty For the ILS knob, press it, rotate it copy 883636401 in the NAV3_IDENT_PACKED Lvar and press the onside LS button on the FCU You should be hearing multiple beeps and squelch and squelch only if the lvar is empty Check also the sides are independant like in the previous steps.

alepouna avatar Nov 19 '23 06:11 alepouna

I gave this a quick skim. It's been a long time and much has changed in the main project!

The captain/fo side vs AMU/RMP is implemented a little differently in the A380. It's just whichever half of the cockpit you are sitting in at the time. We should unify whatever we decide to do so the two planes work the same from the user perspective.

The A380 already has the RMPs and AMUs implemented as discrete systems with bus communication between them in typescript with failures for each component, and I was intending to bring this to the A320 digital RAIM later (3d modelling is in progress for that as well).

I've added a couple of issues that need addressed, and a couple of notes below.

Alright so what should I do? Delete this PR? 😅

juliansebline avatar Jun 08 '24 03:06 juliansebline

Alright so what should I do? Delete this PR? 😅

Noooo, this is good! The 2 things to address are the NAV4 being MMR2 (ILS), and the LS course var. Anything else is future work.

tracernz avatar Jun 08 '24 10:06 tracernz

Alright so what should I do? Delete this PR? 😅

Noooo, this is good! The 2 things to address are the NAV4 being MMR2 (ILS), and the LS course var.

Anything else is future work.

Alright! We'll discuss about it! I agree it's possible to make it more realistic.

Now I am in Greece enjoying 40 degrees C, Gyros (pita sandwich) and sea food until next Sunday

juliansebline avatar Jun 09 '24 08:06 juliansebline

Anyway, in the mean time it would be a good idea to final test it and merge because it became VERY unmaintainable.

I spend too much time rebasing.

I'll create a new PR based on the updated master to address the changes

juliansebline avatar Jun 09 '24 08:06 juliansebline

Alright! We'll discuss about it! I agree it's possible to make it more realistic.

Now I am in Greece enjoying 40 degrees C, Gyros (pita sandwich) and sea food until next Sunday

To further clarify. While I talked about digital RAIM, we will also keep the old ACPs + RMPs as an option in the A32NX, so everything you've done for them is still 💯 . I assumed that without stating it outright before!

tracernz avatar Jun 15 '24 14:06 tracernz