aircraft icon indicating copy to clipboard operation
aircraft copied to clipboard

feat(rmp): SELCAL support

Open juliansebline opened this issue 2 years ago • 3 comments

NOT FINISHED

Summary of Changes

This PR provides support of SELCAL via Altitude (IVAO) and vPilot. Also, it provides control of volume via Altitude UI or ACPs.

Screenshots (if necessary)

References

Additional context

You will have to get in touch with an ATC from IVAO and VATSIM to be able to test.

Me: Julian Sebline [Z+2 fr en esp]#8476 IVAO ATC: Olafie#2111 VATSIM ATC: philsjh#1913

Testing instructions

Altitude

  1. Download and install Altitude here: https://api.ivao.aero/v2/softwares/altitude/5/files/latest/download
  2. PM me on Discord to get the modified binary (if the version is not released yet)
  3. PM the IVAO ATC (Olafie#2111) to sync with him
  4. Open Simvar Watcher and add COM VOLUME:1/2
  5. Set the local frequency
  6. Once SELCAL fired:
    • [ ] You should be able to hear a continuous sound
    • [ ] The light on the on the CALL p/b of the chosen channel should be blinking
    • [ ] Press RESET on the ACP, the sound and blink should stop
    • [ ] Request confirmation of the ATC he has received the acknowledgement (even though in real life it's not like this)
  7. Rotate the volume knobs on Altitude
    • [ ] The respective knobs on the 3 ACPs should be rotating
    • [ ] The respective knobs on the 3 ACPs should be set to the same position/value
    • [ ] The respective simvar should be set to the same value
  8. Rotate the volume knobs on one ACP
    • [ ] The knobs in Altitude should not rotate since the sent value is the greatest between the three ACPs (between activated knobs)
    • [ ] Turn off knobs of ACP 2 and overhead ACP
    • [ ] The respective knob in Altitude should rotate
    • [ ] The respective simvar should be set to the same value

vPilot

  1. Download and install vPilot here: https://vpilot.rosscarlson.dev/Assets/Files/Installers/vPilot-Setup-3.4.6.exe
  2. PM me on Discord to get the modified binary (if the version is not released yet)
  3. PM the VATSIM ATC (philsjh#1913) to sync with him
  4. He told me you can spawn in Dublin
  5. Set the local frequency
  6. Once SELCAL fired:
    • [ ] You should be able to hear a continuous sound
    • [ ] The light on the on the CALL p/b of the chosen channel should be blinking
    • [ ] Press RESET on the ACP, the sound and blink should stop

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, click on the bottom PR tab
  4. Click on the A32NX download link at the bottom of the page

juliansebline avatar Sep 01 '22 08:09 juliansebline

Initial review of the CPP part - did not yet look at the other things. Consider using a better cpp formatting (e.g. ClangFormat) Consider using clang-tidy for some inspections

Hope I find time to look at the rest next week.

Would you have a config file for this?

juliansebline avatar Sep 12 '22 09:09 juliansebline

Initial review of the CPP part - did not yet look at the other things. Consider using a better cpp formatting (e.g. ClangFormat) Consider using clang-tidy for some inspections Hope I find time to look at the rest next week.

Would you have a config file for this?

There is already a config file for the cpp formatting in the repo: .clang-format.

Gurgel100 avatar Sep 12 '22 13:09 Gurgel100

image

frankkopp avatar Sep 12 '22 17:09 frankkopp

Superseded by #7868.

tracernz avatar Mar 29 '23 08:03 tracernz