aircraft
aircraft copied to clipboard
flybywiresim
feat: change prepare4takeoff announcement trigger
Fixes #[issue_no]
Summary of Changes
Changed the "Please Prepare for Takeoff Announcement to be triggered by clicking the TCAS switch to TA/RA from turning Landing Lights on. I thought that since this is usually not done until actually lined up on the runway, it was to late to warn the Flight Attendants about the imminent takeoff.
Screenshots (if necessary)
References
Discussed this issue with @tracernz over the last few months. Asked for assistance in Discord and Pilot grizzlybird [Z+A330] kindly responded and thought that moving this announcement to trigger by the TA/RA switch would make the most sense as it is the last thing done before lining up on active runway.Additional context
Discord username (if different from GitHub):@PatM
Testing instructions
While Taxiing to the runway, rotate the TCAS POSITION SWITCH to "TA/RA" the "Flight Attendants, Please prepare for takeoff" announcement will now play.
How to download the PR for QA
Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.
- Make sure you are signed in to GitHub
- Click on the Checks tab on the PR
- On the left side, click on the bottom PR tab
- Click on the A32NX download link at the bottom of the page
LGTM, please also make a PR on the a32nx-wwise repo as sound.xml is doubled there for development purposes.
Do I need to make a separate fork of that repository-> new branch -> commit again?
On Sun, Aug 7, 2022 at 3:25 PM mico975 @.***> wrote:
LGTM, please also make a PR on the a32nx-wwise repo as sound.xml is doubled there for development purposes.
— Reply to this email directly, view it on GitHub https://github.com/flybywiresim/a32nx/pull/7402#issuecomment-1207479407, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ2MIPSXBYWCKM3EO3AY6DLVYALTBANCNFSM55274I4Q . You are receiving this because you authored the thread.Message ID: @.***>
Do I need to make a separate fork of that repository-> new branch -> commit again?
Yes, just make a PR as usual.
This is a nice QoL thing. Landing lights are not switched on until lined up and cleared for takeoff here... https://youtu.be/GGibKWUL0qw?t=147
The landing lights are switched on at takeoff clearance on most airlines.
Quality Assurance Tester Report
Discord : mico#3145 Object of testing: #7402 Tier of Testing : 1 Date : 08/08/2022
Testing Process: While Taxiing to the runway, rotate the TCAS POSITION SWITCH to "TA/RA" the "Flight Attendants, Please prepare for takeoff" announcement will now play. - OK
Negatives:
N/A
Testing Results: Passed
Conclusions: LGTM
The "before takeoff" or "line up" checklist usually lists the TCAS item as "TA or TA/RA"; is it possible to trigger the announcement when either is selected, rather than only TA/RA? I tend to use TA only when flying with real world traffic.
Please update Audio - Announcements docs as well. https://github.com/flybywiresim/docs/blob/primary/docs/fbw-a32nx/feature-guides/audio.md
Thank you.
