aircraft icon indicating copy to clipboard operation
aircraft copied to clipboard

feat(simbridge): simbridge client

Open Lucky38i opened this issue 2 years ago • 2 comments

Summary of Changes

Client for retrieving various information Simbridge, preliminary PR to be used by other feature implementations. Contains Terrain, CoRoute and Viewer support.

This PR does not require any testing and doesn't provide any inherent function to the aircraft, just used in advance of other features.

Screenshots (if necessary)

References

Additional context

SimBridge is API based, this client aims to abstract any of the HTTP requests to allow devs to focus on implementation on needed features.

Discord username (if different from GitHub): Lucky38i

Testing instructions

None, not required

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, click on the bottom PR tab
  4. Click on the A32NX download link at the bottom of the page

Lucky38i avatar Jul 29 '22 16:07 Lucky38i

How come these functions return the entire response object and not just the necessary data?

ErickSharp avatar Jul 30 '22 01:07 ErickSharp

I am not sure if we want the Terrain interface in this PR on in the one of the terrainmap.

Makes the sync a bit confusing if we need some changes for the terrainmap.

svengcz avatar Aug 01 '22 06:08 svengcz