aircraft icon indicating copy to clipboard operation
aircraft copied to clipboard

refactor: remove old js SD

Open Saschl opened this issue 2 years ago • 1 comments

Fixes #[issue_no]

Summary of Changes

  • [x] point panel.cfg entry to template.html
  • [ ] port permanent data area
  • [ ] port logic (auto switching etc.)
  • [ ] ensure accuracy (font sizes, layout...)
  • [ ] ...?

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub):

Testing instructions

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, click on the bottom PR tab
  4. Click on the A32NX download link at the bottom of the page

Saschl avatar Jul 17 '22 18:07 Saschl

SD on my phone, here we come

Benjozork avatar Jul 17 '22 18:07 Benjozork

Fix lints.

tracernz avatar Jan 04 '23 05:01 tracernz

QA Tester Report

Name: Mr.Blank#6197 Date of testing MM/DD/YYYY:01/09/2023 PR Tested: 7556 Tier of testing:1

Testing technique: tryouts Test Instructions: The logic of the screens has not been touched by this PR so we don't expect any visual changes. However, here some points that can be checked. Make sure all pages are selectable and show correct/meaningful data. Test ECAM ALL button (pages should cycle in a one-second interval) Verify auto-switching behaviour when no page is selected (non exhaustive list following) Deselect any active ecam page when C&D and turn on the API -> APU page should appear Start the engines -> ENG page should show up While taxiing, move any control surface fully and verify the F/CTL page is showing up. When releasing controls, page should switch back after 20s In cruise, CRZ page should be shown Ps-- General observation of any possible weird behavior.

Methodology All as per instruction

Negatives: NIL Testing Results: PASS Conclusions: results were of normal outputs

dragold avatar Jan 09 '23 13:01 dragold

Why don't you port the SD directly to the MSFS Avionics Framework, instead of React?

MicahBCode avatar Jan 09 '23 18:01 MicahBCode

Will come eventually. First step is to get rid of the old pure JS remainders so we unblock some progress (updated build pipeline + remote displays). Port to msfs avionics will take a bit longer as I did not touch the actual pages here.

Saschl avatar Jan 09 '23 18:01 Saschl