aircraft
aircraft copied to clipboard
flybywiresim
feat(rmp): RMP navigation tuning
Fixes #4044 Fixes #7457
Summary of Changes
This PR makes:
- The RMPs able to tune the navigation instruments
- The listening of ident of the different instruments possible
- The Voice button serviceable (cancellation of all idents)
Screenshots (if necessary)
References
https://www.smartcockpit.com/docs/A320-Navigation.pdf (PAGE 24) https://youtu.be/qpL23wnNNEI?t=1770
Real life tests
Additional context
Tune via RMPs:
- [x] ILS
- [x] VOR
- [x] MLS: Cancelled. Will display 808.080
- [x] ADF
MCDU:
- [x] Make RADNAV page unable to accept new entries when NAV button is pushed
- [x] SelectedNavaids page to show RMP if tuned via the RMPs or MAN if tuned manually
- [x] Manage back to auto-tuning: Cancelled because there's not autotuning for now
- [x] Inhibit manual/RMP tuning if below 700 RA, APPR engaged, at least one AP/FD engaged
ND:
- [x] To show M if manually tuned or R if tuned via RMPs
- [x] No DME distance if RMP tuned
Ident knobs:
- [x] VOR 1/2
- [x] MKR
- [x] ILS: Cancelled because we cannot turn on the ident on NAV3
- [x] MLS: Cancelled because we MLS is not simulated
- [x] ADF 1/2
- [x] Voice button
Discord username (if different from GitHub):
Testing instructions
REQUIREMENTS
- Refer to the second comment regarding a file. It will ease the process in SimVarWatcher
- Open SimVarWatcher
- Load the file you have just created
Good luck and thank you for your time.
TEST N°1: enabling/disabling of knobs and volume
Make sure all buttons/knobs are independent. Make sure to play with buttons/knobs of both RMPs
It's normal the RMP 2 does not transmit on any channel by default. It was made to avoid deselect the transmit channel on the RMP 2 to be able to switch between COM1 and 2 on vPilot/Alitude
- Check if there's a weak light on all knobs when they are off (basically, similar to comm knobs)
- Push each volume knob of the navigation part of both RMPs
- [ ] Check if the tooltips match (increase/decrease the volume, turn on/off the ident)
- [ ] They should light up.
- [ ] In Watcher, all SOUND simvars should be set to 1.
- [ ] Dim all the lights via the overhead panel and check if the knobs are dimmed as well
- Rotate each knob. (It's possible no sound will be heard. Not a big deal since custom morse code will come with FMS v2)
- [ ] VOR 1: NAV1 VOLUME simvar should be set to the maximum of the two knobs on RMP1/2.
- [ ] VOR 2: NAV2 VOLUME simvar should be set to the maximum of the two knobs on RMP1/2.
- [ ] MKR: No volume simvar. Just check if it's rotating.
- [ ] ADF 1: Associated ADF VOLUME simvar should be set to the maximum of the two knobs on RMP1/2.
- [ ] ADF 2: Associated ADF VOLUME simvar should be set to the maximum of the two knobs on RMP1/2.
- [ ] ILS: No volume simvar. Just check if it's rotating.
- Reason: ILS is tuned via NAV3 but its volume is unsettable (even though it's set to 100 by default)
- [ ] MLS: Same as ILS. (Will be replaced by GLS once the custom model is made)
- Push VOICE button (to check inhibition of ident. FCOM compliant: only VORs and ADFs are covered)
- [ ] Check the tooltips (Allow/Inhibit the idents)
- [ ] The push button should lights up.
- [ ] NAV1/2 SOUND (for VORs) and ADF1/2 SOUND simvars should be set to 0.
- [ ] Push VOR and ADF knobs should have no effect. Light them back up.
- Push VOICE button once again
- [ ] The push button should be off.
- [ ] NAV1/2 SOUND (for VORs) and ADF SOUND simvars should be set to 1 if at least one knob of each pair is on.
- Push back each volume knob by pair (for example VOR1 Right RMP then VOR1 Left RMP)
- [ ] Each knob light should turn off.
- [ ] Associated SOUND simvar should be set to 0 ONLY IF both knobs are turned off.
TEST N°2: Tuning
Information: Left RMP manages VOR1/ADF1. Right RMP manages VOR2/ADF2. Both RMPs can manage ILS ONLY IF both FMGCs are in nav backup mode (i.e respective NAV push buttons pushed)
Therefore VOR1 = NAV1 VOR2 = NAV2
- Press the VOR then MLS then ILS then ADF push buttons
- [ ] You should NOT be able to make them work
- Push VHF2 on the left RMP (or VHF1 if testing the right one) then push the NAV push button
- [ ] NAV led should lights up
- [ ] RADNAV page on both MCDU should be blank
- [ ] Any entry in the RADNAV page should return "NOT ALLOWED"
- On the FMGC, press DATA then L1 then R6
- [ ] RMP should appear at the top center
- Push VOR push button on the tested RMP
- [ ] The SEL light should be off
- [ ] The push button led should lights up
- [ ] NAV push button led should still be on
- [ ] The active window should display the frequency set in NAV1 (2 for RMP 2) ACTIVE FREQUENCY simvar
- [ ] The standby window should display the frequency set in NAV1 (2 for RMP 2) STANDBY FREQUENCY simvar
- Rotate the rings of standby frequency and the local VOR frequency
- [ ] The min/max values for the outer one are 108/117
- [ ] The inner one goes from 0 to 0 both ways
- Push the transfer push button
- [ ] The frequencies should have switched (check the active window and simvars)
- [ ] The frequency window should display "C-" followed by 3 digits making a number between 0 and 359
- Rotate the same rings as before
- [ ] The outer ring should have no effect
- [ ] The inner ring should increase/decrease the course between 0 and 359
- Push the transfer push button
- [ ] NAV OBS 1/2 simvars should be updated
- [ ] Active frequency should be in active and standby frequency windows
- [ ] A 'R' (for Remote) should be next to each reference of the VOR on the ND (Rotate the Rose knob to VOR)
- Push the transfer button again to pass in course mode and go to the next step
- Push ILS push button (Same tests as VOR (from 3.) and NAV3 simvars)
- [ ] Course mode should have disappeared, back to frequency mode. No flickering observed.
- [ ] Active frequency simvar settable ONLY IF both RMP in nav backup mode (FCOM compliant)
- [ ] Frequencies min/max 108/111 with the outer knob
- [ ] No DME distance should be displayed on the ND
- Push MLS push button
- [ ] Nothing should happen
- Push ADF push button (same tests as VOR (from 3.). This time with ADF simvars)
- [ ] No course selection possible
- [ ] Frequencies between 190.0 and 1750.0
- [ ] The outer knob selects the integer digits, the inner one the decimal (0 or 0.5 only).
- [ ] The 'R' should still be visible
- Push NAV push button on the tested RMP
- [ ] NAV push button led should goes off
- [ ] On the FMGC, press DATA then L1 then R6: Auto should appear
- [ ] Current nav receiver's led should goes off
- [ ] The RMP should be displaying previously selected VHF
- [ ] RADNAV page no longer blank
- [ ] The 'R' have disappeared from the ND
- [ ] In the Watcher, all ACTIVE frequencies should be set to 0
Repeat for both RMPs
TEST N°3: Inhibit at low altitude
This test to be FCOM compliant. You should not be able to tune anything via the RMP if below 700 RA, APPR engaged, at least one AP/FD engaged. In this part, I'm assuming the transfer button does not allow us to switch frequencies. I don't know the real behavior though.
- Press NAV then VOR
- Activate APPR and one AP
- Tune a standby frequency
- Fly until passing 700 RA descending
- Press the transfer button
- [ ] Nothing should happen
How to download the PR for QA
Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.
- Make sure you are signed in to GitHub
- Click on the Checks tab on the PR
- On the left side, click on the bottom PR tab
- Click on the A32NX download link at the bottom of the page
To merge into the master after #7105 because there will be some conflicts I think.
Some lines are in my first commit AND in #7105 too, I don't know why. Plus, the PR updates the same files.
COPY THIS INTO A FILE WITH EXTENSION ".simvars" then load it into SimVarWatcher.
ADF SOUND:1,Bool,False ADF SOUND:2,Bool,False ADF VOLUME:1,percent,False ADF VOLUME:2,percent,False ADF ACTIVE FREQUENCY:1,Hz,False ADF ACTIVE FREQUENCY:2,Hz,False ADF STANDBY FREQUENCY:1,Hz,False ADF STANDBY FREQUENCY:2,Hz,False NAV VOLUME:1,percent,False NAV VOLUME:2,percent,False NAV VOLUME:3,percent,False NAV SOUND:1,Bool,False NAV SOUND:2,Bool,False NAV SOUND:3,Bool,False NAV ACTIVE FREQUENCY:1,Hz,False NAV ACTIVE FREQUENCY:2,Hz,False NAV ACTIVE FREQUENCY:3,Hz,False NAV STANDBY FREQUENCY:1,Hz,False NAV STANDBY FREQUENCY:2,Hz,False NAV STANDBY FREQUENCY:3,Hz,False NAV OBS:1,degrees,False NAV OBS:2,degrees,False NAV OBS:3,degrees,False
I think MLS button should just do nothing, to avoid confusion.
Disabled in BaseRadioPanels.tsx. Still implemented in the XML behaviours.
Quality Assurance Tester Report
Discord : mico#3145 Object of testing: #7241 Tier of Testing : 1 Date : 15/09/2022
Testing Process: TEST N°1: enabling/disabling of knobs and volume Make sure all buttons/knobs are independent. - OK Make sure to play with buttons/knobs of both RMPs - OK
It's normal the RMP 2 does not transmit on any channel by default. It was made to avoid deselect the transmit channel on the RMP 2 to be able to switch between COM1 and 2 on vPilot/Alitude
Check if there's a weak light on all knobs when they are off (basically, similar to comm knobs) - OK Push each volume knob of the navigation part of both RMPs Check if the tooltips match (increase/decrease the volume, turn on/off the ident) - OK They should light up. - OK In Watcher, all SOUND simvars should be set to 1. Dim all the lights via the overhead panel and check if the knobs are dimmed as well - OK Rotate each knob. (It's possible no sound will be heard. Not a big deal since custom morse code will come with FMS v2) VOR 1: NAV1 VOLUME simvar should be set to the maximum of the two knobs on RMP1/2. - OK VOR 2: NAV2 VOLUME simvar should be set to the maximum of the two knobs on RMP1/2. - OK MKR: No volume simvar. Just check if it's rotating. - OK ADF 1: Associated ADF VOLUME simvar should be set to the maximum of the two knobs on RMP1/2. - OK ADF 2: Associated ADF VOLUME simvar should be set to the maximum of the two knobs on RMP1/2. - OK, stuck at 100 because of lack of implementation on MSFS side ILS: No volume simvar. Just check if it's rotating. - OK Reason: ILS is tuned via NAV3 but its volume is unsettable (even though it's set to 100 by default) MLS: Same as ILS. (Will be replaced by GLS once the custom model is made) - OK Push VOICE button (to check inhibition of ident. FCOM compliant: only VORs and ADFs are covered) - OK Check the tooltips (Allow/Inhibit the idents) The push button should lights up. NAV1/2 SOUND (for VORs) and ADF1/2 SOUND simvars should be set to 0. - OK Push VOR and ADF knobs should have no effect. Light them back up. - OK Push VOICE button once again The push button should be off. - OK NAV1/2 SOUND (for VORs) and ADF SOUND simvars should be set to 1 if at least one knob of each pair is on. - OK Push back each volume knob by pair (for example VOR1 Right RMP then VOR1 Left RMP) Each knob light should turn off. - OK Associated SOUND simvar should be set to 0 ONLY IF both knobs are turned off. - OK
TEST N°2: Tuning Information: Left RMP manages VOR1/ADF1. Right RMP manages VOR2/ADF2. Both RMPs can manage ILS ONLY IF both FMGCs are in nav backup mode (i.e respective NAV push buttons pushed)
Therefore VOR1 = NAV1 VOR2 = NAV2
Press the VOR then MLS then ILS then ADF push buttons You should NOT be able to make them work - OK Push VHF2 on the left RMP (or VHF1 if testing the right one) then push the NAV push button NAV led should lights up - OK RADNAV page on both MCDU should be blank - OK Any entry in the RADNAV page should return "NOT ALLOWED" - OK On the FMGC, press DATA then L1 then R6 RMP should appear at the top center - OK Push VOR push button on the tested RMP The SEL light should be off - OK The push button led should lights up - OK NAV push button led should still be on - OK The active window should display the frequency set in NAV1 (2 for RMP 2) ACTIVE FREQUENCY simvar - OK The standby window should display the frequency set in NAV1 (2 for RMP 2) STANDBY FREQUENCY simvar - Rotate the rings of standby frequency and the local VOR frequency The min/max values for the outer one are 108/117 - OK The inner one goes from 0 to 0 both ways - OK Push the transfer push button The frequencies should have switched (check the active window and simvars) - OK The frequency window should display "C-" followed by 3 digits making a number between 0 and 359 - OK Rotate the same rings as before The outer ring should have no effect - OK The inner ring should increase/decrease the course between 0 and 359 - OK Push the transfer push button NAV OBS 1/2 simvars should be updated - OK Active frequency should be in standby frequency window and set into STANDBY frequency simvar too - OK No DME distance should be displayed on the PFD - OK A 'R' (for Remote) should be next to each reference of the VOR on the ND (Rotate the Rose knob to VOR) - OK Push the transfer button again to pass in course mode and go to the next step Push ILS push button (Same tests as VOR (from 3.) and NAV3 simvars) Course mode should have disappeared, back to frequency mode. No flickering observed. - OK Active frequency simvar settable ONLY IF both RMP in nav backup mode (FCOM compliant) - OK Frequencies min/max 108/111 with the outer knob - OK Push MLS push button 808.080 should appear to show it's not implemented. Not enough references. Will be replaced with GLS. - OK, doesn't do anything anyway Push ADF push button (same tests as VOR (from 3.). This time with ADF simvars) No course selection possible - OK Frequencies between 190.0 and 1750.0 - OK The outer knob selects the integer digits, the inner one the decimal (0 or 0.5 only). - OK Once at 1750.0, it should not be possible to go to 1750.5 with the inner knob - OK The 'R' should still be visible - OK Push NAV push button on the tested RMP NAV push button led should goes off - OK On the FMGC, press DATA then L1 then R6: Auto should appear - OK Current nav receiver's led should goes off - OK The RMP should be displaying previously selected VHF - OK RADNAV page no longer blank - OK The 'R' have disappeared from the ND - OK In the Watcher, all ACTIVE frequencies should be set to 0 - OK Repeat for both RMPs - OK
TEST N°3: Inhibit at low altitude - OK This test to be FCOM compliant. You should not be able to tune anything via the RMP if below 700 RA, APPR engaged, at least one AP/FD engaged. In this part, I'm assuming the transfer button does not allow us to switch frequencies. I don't know the real behavior though.
Press NAV then VOR Activate APPR and one AP Tune a standby frequency Fly until passing 700 RA descending Press the transfer button Nothing should happen
Negatives:
See above
Testing Results: Almost Passed
Conclusions: Soon to be 🚀
