fix(rmp): RMP behaviour and lights

[juliansebline]

Fixes #344 Fixes #164 Fixes #5033 Fixes #4591

Summary of Changes

This commit fixes the RMPs/ACPs's behaviour (VHFs only), their electrical power and add VHF 3 voice/data mode.

Screenshots (if necessary)

References

Additional context

Thanks shomas#2719 for the pîctures in the real aircraft!

My discord: Julian Sebline#8476

Testing instructions

Keep in mind both RMPs and ACPs are independent

1. Open SimvarWatcher and load the config file found in the last comment.
2. At startup:
   • [ ] CALL1 should be active on both sides
   • [ ] VHF1/2 volumes knobs should be on with values 0.8 and 0.4 (respectively)
   • [ ] Left RMP should be set with VHF1
   • [ ] Right RMP should be set with VHF2
   • [ ] Respective SEL light should not be lit
   • [ ] Simvars RECEIVE ALL and RECIEVE ALL should be set to 1 (for vPilot)
3. On the left RMP, press VHF2 then VHF3
   • [ ] The left SEL led AND word should lit in orange on both sides
   • [ ] Back to VHF1, the lights should go off
4. On the right RMP, press VHF1 then VHF3
   • [ ] The right SEL led AND word should lit in orange on both sides
   • [ ] Back to VHF2, the lights should go off
5. On both sides, press VHF1/2/3 volume knobs
   • [ ] Each knob should turn on/off independently
   • [ ] All knobs can be on/off
   • [ ] Respective simvar should be set to 1 IF at least one knob of each side is on
   • [ ] Respective simvar should be set to 0 IF each knob of each side is off
   • [ ] When off, rotate a knob should be harder (to simulate real behaviour)
6. On both sides, rotate VHF1/2/3 volume knobs
   • [ ] Each knob should rotate independently
   • [ ] Respective simvar should be set to the greatest value of both knobs
7. Turn off all volumes knobs
   • [ ] Rotate them should not update their respective simvar
   • [ ] Turn them on, the simvar should be updated with the value of the knob OR the max value between the two knobs if both on
8. On both sides, turn OFF all CALL (related to VHFs) push buttons
   • [ ] Their respective light is off
   • [ ] The simvars COM TRANSMIT are set to 0
   • [ ] The simvars PILOT/COPILOT TRANSMITTER TYPE are set to 4 (None)
9. On both sides, turn ON all CALL (related to VHFs) push buttons
   • [ ] It's NOT possible to have two or more CALL push button active on one RMP
   • [ ] The simvars PILOT/COPILOT TRANSMITTER TYPE are set to 0 for COM1, 1 for COM2, 2 for COM3
   • [ ] The respective simvars COM TRANSMIT are set to 1 if at least one of the respective push buttons is on
10. Push VHF3 on each RMP
    • [ ] The word DATA should appear centered in the active window
    • [ ] A frequency should appear in the standby window
11. Push the transfer key
    • [ ] The text "VHF 3 VOICE" should appear on the ECAM (the underlying logic is not implemented yet)
    • [ ] Push the transfer key once gain, the message should disappear
12. Rotate the knobs to change a frequency
    • [ ] Frequency decimal can now return to 0 after .975 even if the integer is 136 (tested irl)

For this part, refer to this link

It is very likely points 12 and 13 fail the test. I have just realized I did not implement the "unusable mechanism". I will implement it in the second PR even though I don't know how it is in real life. I will make the frequency windows blank and knobs off.

13. Disconnect DC BUS 1 and AC BUS 1
    • [ ] VHF 3 (knob and push button) should be unusable
14. Disconnect DC BUS 2 and AC BUS 2
    • [ ] VHF 2 (knob and push button) should be unusable
    • [ ] RMP 2 should be unusable

At this point, only VHF 1, RMP 1 and both ACPs should be usable. Engines, APU, GPU off.

15. Disconnect DC ESS BUS and AC ESS BUS
    • [ ] Everything should be unusable

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.

1. Make sure you are signed in to GitHub
2. Click on the Checks tab on the PR
3. On the left side, click on the bottom PR tab
4. Click on the A32NX download link at the bottom of the page

[juliansebline]

Thank you for your comment/

Would you have the precise list of phases affected ? I cannot find it on the internet. I suppose CLB CRZ DESCENT ?

Thank you

De : Michael @.> Envoyé le :mercredi 27 avril 2022 00:46 À : @.> Cc : Julian @.>; @.> Objet :Re: [flybywiresim/a32nx] fix(rmp): RMP behavior and lights (PR #7105)

@tracernz commented on this pull request.

In src/instruments/src/EWD/elements/PseudoFWC.tsxhttps://github.com/flybywiresim/a32nx/pull/7105#discussion_r859204881:

@@ -1349,6 +1351,17 @@ const PseudoFWC: React.FC = () => {

         sysPage: -1,

         side: 'RIGHT',

     },

•    '0000690': // VHF 3 VOICE
  

•    {
  

•        flightPhaseInhib: [],
  

•        simVarIsActive: voiceVHF3 !== 0,
  

Shouldn't that go in flightPhaseInhib?

— Reply to this email directly, view it on GitHubhttps://github.com/flybywiresim/a32nx/pull/7105#discussion_r859204881, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACLV5F4QOPDBLKYLJN23NK3VHBW4BANCNFSM5UGSVFCQ. You are receiving this because you authored the thread.Message ID: @.***>

[tracernz]

Thank you for your comment/ Would you have the precise list of phases affected ? I cannot find it on the internet. I suppose CLB CRZ DESCENT ?

BehEh provided the code above.

[juliansebline]

Put these lines into a file with the extension .simvars and load it into the Watcher.

COM TRANSMIT:1,Bool,False COM TRANSMIT:2,Bool,False COM TRANSMIT:3,Bool,False COM VOLUME:1,percent over 100,False COM VOLUME:2,percent over 100,False COM VOLUME:3,percent over 100,False PILOT TRANSMITTER TYPE,Enum,False COPILOT TRANSMITTER TYPE,Enum,False

[mico975]

Quality Assurance Tester Report

Discord : mico#3145 Object of testing: (#7105 Tier of Testing : 1 Date : 08/08/2022

Testing Process:

At startup: CALL1 should be active on both sides - OK VHF1/2 volumes knobs should be on with values 0.8 and 0.4 (respectively) - OK Left RMP should be set with VHF1 - OK Right RMP should be set with VHF2 - OK Respective SEL light should not be lit - OK Simvars RECEIVE ALL and RECIEVE ALL should be set to 1 (for vPilot) - OK

On the left RMP, press VHF2 then VHF3 The left SEL led AND word should lit in orange on both sides - OK Back to VHF1, the lights should go off - OK

On the right RMP, press VHF1 then VHF3 The right SEL led AND word should lit in orange on both sides - OK Back to VHF2, the lights should go off - OK

On both sides, press VHF1/2/3 volume knobs Each knob should turn on/off independently - OK All knobs can be on/off - OK Respective simvar should be set to 1 IF at least one knob of each side is on - OK Respective simvar should be set to 0 IF each knob of each side is off - OK When off, rotate a knob should be harder (to simulate real behaviour) - OK

On both sides, rotate VHF1/2/3 volume knobs Each knob should rotate independently - OK Respective simvar should be set to the greatest value of both knobs - OK

Turn off all volumes knobs Rotate them should not update their respective simvar - OK Turn them on, the simvar should be updated with the value of the knob OR the max value between the two knobs if both on - OK

On both sides, turn OFF all CALL (related to VHFs) push buttons Their respective light is off - OK The simvars COM TRANSMIT are set to 0 - OK The simvars PILOT/COPILOT TRANSMITTER TYPE are set to 4 (None) - OK

On both sides, turn ON all CALL (related to VHFs) push buttons It's NOT possible to have two or more CALL push button active on one RMP - OK The simvars PILOT/COPILOT TRANSMITTER TYPE are set to 0 for COM1, 1 for COM2, 3 for COM3 - OK The respective simvars COM TRANSMIT are set to 1 if at least one of the respective push buttons is on - OK

Push VHF3 on each RMP The word DATA should appear centered in the active window - OK A frequency should appear in the standby window - OK

Push the transfer key The text "VHF 3 VOICE" should appear on the ECAM (the underlying logic is not implemented yet) - OK Push the transfer key once gain, the message should disappear - OK

Rotate the knobs to change a frequency Frequency decimal can now return to 0 after .975 even if the integer is 136 (tested irl) - OK

Disconnect DC BUS 1 and AC BUS 1 - not tested VHF 3 (knob and push button) should be unusable

Disconnect DC BUS 2 and AC BUS 2 - not tested VHF 2 (knob and push button) should be unusable RMP 2 should be unusable At this point, only VHF 1, RMP 1 and both ACPs should be usable. Engines, APU, GPU off.

Disconnect DC ESS BUS and AC ESS BUS - not tested Everything should be unusable

Negatives:
See above in testing process

Testing Results: Passed (electrical system config still needs to be tested by someon)

Conclusions: LGTM

[2hwk]

Disconnect DC BUS 1 and AC BUS 1

• [x] VHF 3 (knob and push button) should be unusable

Disconnect DC BUS 2 and AC BUS 2

• [x] VHF 2 (knob and push button) should be unusable
• [x] RMP 2 should be unusable
• [x] At this point, only VHF 1, RMP 1 and both ACPs should be usable. Engines, APU, GPU off.

Disconnect DC ESS BUS and AC ESS BUS

• [x] Everything should be unusable

Remaining items passed