flynamo icon indicating copy to clipboard operation
flynamo copied to clipboard

feat: remove DynamodbWrapper client dependency

Open lfantone opened this issue 4 years ago • 4 comments

lfantone avatar Jan 21 '21 15:01 lfantone

What the wrapper is doing for those cases is to be able to do an unlimited amount of request to the database taking care of the 25 request limit that the aws-sdk client has. So maybe it is a good idea to keep the wrapper client for those batch methods.

Thoughts?

lfantone avatar Jan 22 '21 14:01 lfantone

:loop: Code coverage

Filename Statements Branches Functions Lines
src/with-paginator.js 100% 95.83% 100% 100%
src/update.js 100% 100% 100% 100%
src/wrapper.js 95% 100% 83.33% 100%
src/table-name.js 100% 100% 100% 100%
src/return-values.js 100% 100% 100% 100%
src/map-merge-args.js 100% 100% 100% 100%
src/cast-array.js 100% 100% 100% 100%
src/generate-key.js 100% 100% 100% 100%
src/and-then.js 100% 100% 100% 100%
src/builders/append.js 100% 100% 100% 100%
src/builders/catcon.js 100% 100% 100% 100%
src/builders/put.js 100% 100% 100% 100%
src/builders/update-expression.js 100% 100% 100% 100%
src/batch-get-item.js 100% 100% 100% 100%
src/get.js 100% 100% 100% 100%
src/query.js 100% 75% 100% 100%
src/remove.js 100% 100% 100% 100%
src/batch-write-item.js 100% 100% 100% 100%
src/generate-item.js 100% 100% 100% 100%
src/insert.js 100% 100% 100% 100%
src/builders/remove.js 100% 100% 100% 100%
src/get-all.js 100% 60% 100% 100%
src/count.js 100% 100% 100% 100%
src/describe-table.js 100% 100% 100% 100%

github-actions[bot] avatar Jan 26 '21 09:01 github-actions[bot]

What the wrapper is doing for those cases is to be able to do an unlimited amount of request to the database taking care of the 25 request limit that the aws-sdk client has. So maybe it is a good idea to keep the wrapper client for those batch methods.

Thoughts?

@lfantone we may need to drop the dependency because it's blocking the upgrade to aws-sdk v3. Maybe we can bring the implementation for the batch methods to flynamo itself?

crash7 avatar Apr 14 '24 20:04 crash7

Yes, feel free to remove it

lfantone avatar Apr 14 '24 21:04 lfantone