dockerfile-node icon indicating copy to clipboard operation
dockerfile-node copied to clipboard

Better support for vite

Open rubys opened this issue 2 years ago • 4 comments
trafficstars

See: https://community.fly.io/t/vite-not-found-on-ci-deploy-from-github/13064

Best solution is likely to install nginx and copy the build output to /usr/share/nginx/html.

rubys avatar May 24 '23 00:05 rubys

As the Remix team is working on the transition to Vite (instead of ESBuild), it would be awesome if this could be supported 😍

MichaelDeBoey avatar Oct 21 '23 21:10 MichaelDeBoey

I'd need to know a bit more as there are so many ways to use Vite. For example, if you look at the community.fly.io link from May you will see that node isn't needed at all during runtime for that example, but undoubtedly for Remix node is needed.

If npm run build produces static assets, and those assets are served using express or equivalent, there may not need to be any change at all to the Dockerfile.

rubys avatar Oct 22 '23 14:10 rubys

undoubtedly for Remix node is needed

Remix also supports Cloudflare (obviously not in scope of this lib), Bun & Deno

MichaelDeBoey avatar Oct 22 '23 14:10 MichaelDeBoey

despite the name, dockerfile-node supports bun. I haven't tried Deno yet.

rubys avatar Oct 22 '23 23:10 rubys