rnote icon indicating copy to clipboard operation
rnote copied to clipboard

Move highlighting and constraints from 'Shape Configuration' popover to new 'Shaper Extra' popover

Open anesthetice opened this issue 3 months ago • 7 comments

fixes #1504

Two things left to iron out:

  1. is "Shaper Extra" the best way to describe what the new popover contains?
  2. padding seems a little short between end of 'Highlighting' and 'Constraints'

anesthetice avatar Sep 12 '25 22:09 anesthetice

unnamed

anesthetice avatar Sep 12 '25 22:09 anesthetice

@Doublonmousse Thanks for taking the time to review this PR, I'll try to work on it later today, I think naming the new popup Shape Configuration (2/2) is better than the current Shaper Extra, but still feels a little off, as it wouldn't be clear why these two were made separate...

What do you think about renaming what is currently called Shape Configuration to Shape Styling (and re-using the previous icon that changes depending on whether the Smooth or Rough style is enabled); and instead of Shaper Extra just Shaper Configuration?

As for implementing next/previous page navigation, I'm not in favor, as that would increase the steps needed to change something.

anesthetice avatar Oct 09 '25 10:10 anesthetice

@Doublonmousse Thanks for taking the time to review this PR, I'll try to work on it later today, I think naming the new popup Shape Configuration (2/2) is better than the current Shaper Extra, but still feels a little off, as it wouldn't be clear why these two were made separate...

What do you think about renaming what is currently called Shape Configuration to Shape Styling (and re-using the previous icon that changes depending on whether the Smooth or Rough style is enabled); and instead of Shaper Extra just Shaper Configuration?

Then the gear icon would be used for the second panel I guess. Yes that makes sense and it's also a little more coherent/useful that what we have now (so we know both the shape and the style mode)

As for implementing next/previous page navigation, I'm not in favor, as that would increase the steps needed to change something.

I would have kept the two buttons but added one to switch from one popup to the other. Although after the change of icon it's not needed anymore because you'd know where to click in the first place

Doublonmousse avatar Oct 11 '25 13:10 Doublonmousse

I am skeptical about a separate menu, what about adding a second page to the original menu?

flxzt avatar Oct 24 '25 09:10 flxzt

I am skeptical about a separate menu, what about adding a second page to the original menu?

Would be more elegant but less nice to use in my opinion; could we maybe compromise with a scrollable popover with a fixed height?

anesthetice avatar Oct 24 '25 17:10 anesthetice

Or alternatively a second page containing only the constraints might work, as that parameter is probably less often changed

anesthetice avatar Oct 24 '25 17:10 anesthetice

yes, we should definitely re-order all items so that only the least frequently used are on the second page.

flxzt avatar Oct 24 '25 17:10 flxzt