flxzt
Shape Tool settings not opening in Windows after building from MSYS2
Describe the bug
I was using the 0.12 version of RNote when I found out you can build the app through MSYS2. I tried building it and everything went smoothly in the process of installation. The problem is when I open the rnote.exe in C:\msys64\mingw64\bin\rnote.exe and go to shape building tool, the settings icon below the shape selector doesn't work. I click it and nothing happens
To Reproduce
Steps to reproduce the behavior:
- Build RNote(v 0.13) through MSYS2 in Windows
- Open the app and go to the shape tool
- Click on the settings icon below the shape selector
- Nothing happens
Expected behavior
A pop-up of various options like 'Enable Constraints' like before
Console Output
After running the command 'rnote' in msys2 terminal and opening the app through there, and then reproducing the bug, I get this warning/error:
Desktop:
- OS: Windows 11 23H2
- App Version: RNote v0.13.0
- Installation Source: Github Repo, MSYS2
- Input Source: Mouse and Keyboard, External Graphics Tablet
Additional context
I did build RNote once a few weeks ago, and it was still in this version, but then it worked totally fine, but after building it today, and running it, this error occurs
Can you detail more the versions used
- For rnote the commit used (cd931c1 maybe ?)
- For msys the gtk/libadwaita version
For now I can't repro on my machine (though I'm on a locally built dev version for gtk, with version 4.19.4-cd6e4d755c)
The repo I cloned and built the app from has the commit cd931c145c950391a3e7ba4fff02bc27dbee702a as the latest one. I think it is the same commit you suggested in your reply.
As for the gtk version, it is 4.18.6
And libadwaita version is 1.7.4
Here's a screenshot after running the meson setup --prefix=C:/msys64/mingw64 _mesonbuild:
Actually, I looked through the repo issues for a bit, and latest significant merge done yesterday was this feature #1210 , which introduced styled lines(dotted, dashed) so, could this be causing this issue by any chance? Because I reverted my cloned repo 1 commit before this merge, and after building it, everything worked perfectly, only after feat #1210 does this problem start
Ruh roh, sorry about that, "It worked on my machine" might not be sufficient here, I'll try to build Rnote on windows and reproduce the issue tonight, I already suspect the changes I made to shaperpage.ui (maybe inconsistent width-request?) might be the cause
I always wanted styled lines in RNote and was waiting for such a update, who knew it just got added yesterday!😁Thanks for looking into this and adding this feature! Do let me know if you want to anything else about the bug.
Are you running rnote from the msys console or doing meson compile build-installer -C _mesonbuild then installing the exe ?
Edit : after using the msys latest packages on the latest main, on my default config it doesn't reproduce.
But it does reproduce if I change the resolution of the screen to be much less tall.
I think gtk will just not show the popover if it's larger vertically than the current display. So the only difference between the commits is that the popup is larger verticallty.
I am really just following the instructions given in Build Windows.md
So, according to that, I just executed the following commands one by one after cloning the repo:
meson setup --prefix=C:/msys64/mingw64 _mesonbuild
meson compile -C _mesonbuild
meson install -C _mesonbuild
After this, I just run the rnote command from the console
Edit: So, if it's the height of the popup is more than before, is there something I can do from my side to fix this bug?
Also tried reproducing the issue on windows, same results as Doublonmousse; as for potential fixes, maybe the following would work?
- moving
constraintsandhighlightingto their own popover - making the current popover widget scroll-able with a lower base height
I would say, the first option is more preferrable. I am using a stylus more often than not when working in RNote, so it would be more convenient to just tap a few times to get to my desired settings rather than scrolling down the popover. Windows Ink is also wonky with scrolling sometimes, so the first option seems the most fitting.
@anesthetice Would it be possible for you to give a estimate how much time will this take to fix?
@anesthetice Would it be possible for you to give a estimate how much time will this take to fix?
Hopefully less than a week, just currently tangled by a more pressing project...
Maybe this weekend if I find the time 👍
@anesthetice Oh, all right. I just wanted to know a timeframe so I can stop checking everyday and directly check after that period.
@anesthetice Just a reminder about this, so this doesn't end up as an open forever issue😅
@anesthetice I know I am very very late, but yes, this works perfectly. It fixed the bug and I can create dashed lines and dotted lines and also access the settings. Really thanks for looking into this issue😊 Should I close this issue or wait till this PR gets merged??
Happy to hear that it works @SaiShubham624, normally the issue will be closed automatically when the PR is merged so you don't have to close it manually