Felix Obenhuber
Felix Obenhuber
> Hello @flxo. The hot paths that you mention use generic functions (eg. `impl AsRef`). According to [this discussion on Reddit](https://www.reddit.com/r/rust/comments/16ziv0i/comment/k3ex0pb), in release builds the generic functions are inlined. Furthermore,...
@dependabot squash and merge
> hey @flxo , any idea why this might be happening? No. I'd check with various Rust versions in a matrix to see if it's a compiler bug specific to...
From an even higher perspective I don't get why there's a separation between `AsyncClient` and `EventLoop`. Maybe a relict from the sync versions and the intention is to keep them...
> Hey, please check if i understood this correctly: > > * if incoming _packet_ comes before the pending throttle ( in case if there were some _pending requests_ ),...
> Loved the [Codec](https://github.com/flxo/rumqtt/blob/062dc2872dc01790fcbf91c9d8c08d63d6bf167d/rumqttc/src/v5/framed.rs#L30) implementation, let's start by implementing that in the first PR? I'll take this up if you are ok with it. We can go about this by...
> > Alternatively reuse the Framed instance from Network. > > That sounds like a great option, we could just as well re-establish a connection and use the buffers as...
A note or example about [oneshot::spawn](https://docs.rs/futures/0.1.25/futures/sync/oneshot/fn.spawn.html?search=) for any kind of "cancellation" might be also good to add.
I just stumbled across [this PR](https://github.com/tokio-rs/tokio/pull/638) that adds `tokio::spawn_handle` and thought it's worth to mention it here. It basically provides the same functionality as `oneshot::spawn`.
Hm. Using a regex here sounds unintuitive to me. I'd suggest to use a list of `u32` or even better `pid_t`. Pids are more or less random and you won't...