Skip git manifests deletion

[invin12]

Optionally skip manifests deletion from git repository on terraform destroy

[swade1987]

@invin12 you need to run make docs and submit the changes.

[invin12]

@invin12 you need to run make docs and submit the changes.

All done

[swade1987]

Thanks, @invin12. Would you be okay with waiting until I get @stefanprodan to approve and merge #615, as it's a big refactor/simplification of the documentation? Once we have that merged, we can merge your changes over the top.

[invin12]

Thanks, @invin12. Would you be okay with waiting until I get @stefanprodan to approve and merge #615, as it's a big refactor/simplification of the documentation? Once we have that merged, we can merge your changes over the top.

Of course I don't mind, thanks!

[swade1987]

@invin12 could you please do the following:

1. Rebase your branch against the main branch
2. Run pre-commit install
3. Run make docs
4. Commit all changes.
5. Squash everything into a single commit.

Many thanks in advance.

[invin12]

@invin12 could you please do the following:

1. Rebase your branch against the main branch
2. Run pre-commit install
3. Run make docs
4. Commit all changes.
5. Squash everything into a single commit.

Many thanks in advance.

All done

[swade1987]

@invin12, can I propose we reverse your logic and return if the user chooses not to delete the manifests? This just means we don't have to have the whole thing wrapped in a massive if block.

[invin12]

@invin12, can I propose we reverse your logic and return if the user chooses not to delete the manifests? This just means we don't have to have the whole thing wrapped in a massive if block.

Ok, logic is changed.

[swade1987]

We will need to wait for @stefanprodan to get back next week to approve and merge this @invin12

[swade1987]

Closing due to inactivity will be tracking via https://github.com/fluxcd/terraform-provider-flux/pull/650