terraform-provider-flux
terraform-provider-flux copied to clipboard
make generated kustomize.yaml valid yaml
yamllint fails on the generated yaml as it starts with an empty line and not with ---
created also an issue for it: https://github.com/fluxcd/terraform-provider-flux/issues/352
@jodok, any chance you could resolve the conflicts here, please? Apart from that the changes LGTM
@jodok, could you please rebase and make this a single commit? I will then approve it and get @stefanprodan to do what is necessary.
@jodok could you please do the following:
- Rebase your branch against the main branch
- Run
pre-commit install
- Run
make docs
- Commit all changes.
- Squash everything into a single commit
Many thanks in advance.
@jodok could you please do the following: ... 2. Run
pre-commit install
i didn't figure out how to run this interactively - however it seems the githooks run it automatically. plz let me know in case sth else is missing.
@jodok its not the end of the world as they are running in CI anyway.
Fixes #352
@jodok, using the most recent version of the provider and the following configuration
resource "flux_bootstrap_git" "this" {
depends_on = [github_repository_deploy_key.this]
path = "clusters/my-cluster"
}
The following kustomization.yaml
file is created and committed to git ...
From a YAML perspective, this file is fine; therefore, I will close this PR and the corresponding issue.
If you did something different to cause an issue please raise a new bug issue.