terraform-provider-flux icon indicating copy to clipboard operation
terraform-provider-flux copied to clipboard

make generated kustomize.yaml valid yaml

Open jodok opened this issue 1 year ago • 4 comments

yamllint fails on the generated yaml as it starts with an empty line and not with ---

jodok avatar Dec 28 '22 17:12 jodok

created also an issue for it: https://github.com/fluxcd/terraform-provider-flux/issues/352

jodok avatar Dec 28 '22 17:12 jodok

@jodok, any chance you could resolve the conflicts here, please? Apart from that the changes LGTM

swade1987 avatar Mar 24 '24 15:03 swade1987

@jodok, could you please rebase and make this a single commit? I will then approve it and get @stefanprodan to do what is necessary.

swade1987 avatar Mar 26 '24 11:03 swade1987

@jodok could you please do the following:

  1. Rebase your branch against the main branch
  2. Run pre-commit install
  3. Run make docs
  4. Commit all changes.
  5. Squash everything into a single commit

Many thanks in advance.

swade1987 avatar Mar 27 '24 20:03 swade1987

@jodok could you please do the following: ... 2. Run pre-commit install

i didn't figure out how to run this interactively - however it seems the githooks run it automatically. plz let me know in case sth else is missing.

jodok avatar Mar 27 '24 22:03 jodok

@jodok its not the end of the world as they are running in CI anyway.

swade1987 avatar Mar 27 '24 22:03 swade1987

Fixes #352

swade1987 avatar Mar 27 '24 22:03 swade1987

@jodok, using the most recent version of the provider and the following configuration

resource "flux_bootstrap_git" "this" {
  depends_on = [github_repository_deploy_key.this]

  path = "clusters/my-cluster"
}

The following kustomization.yaml file is created and committed to git ...

Screenshot 2024-04-09 at 11 39 55

From a YAML perspective, this file is fine; therefore, I will close this PR and the corresponding issue.

If you did something different to cause an issue please raise a new bug issue.

swade1987 avatar Apr 09 '24 10:04 swade1987