pkg icon indicating copy to clipboard operation
pkg copied to clipboard

Why do we need to check for a strict semver in ParseVersion?

Open mo-rieger opened this issue 9 months ago • 0 comments

I stumbled on this, when I was using an ImagePolicy with policy.semver.range defined.

Some repositories strip the patch version when doing a minor release, e.g. kubernetes-event-exporter. The image-reflector-controller cant evaluate the latest tag of such tags and logs: unable to determine latest version from provided list.

ImagePolicy

apiVersion: image.toolkit.fluxcd.io/v1beta2
kind: ImagePolicy
metadata:
  name: kubernetes-event-exporter
spec:
  imageRepositoryRef:
    name: kubernetes-event-exporter
  policy:
    semver:
      range: ^1.1

We see this because we check for a strict semver in ParseVersion, even though semver.NewVersion is used to return the version which could actually handle missing patch versions, like 1.1.

mo-rieger avatar May 13 '24 10:05 mo-rieger