kustomize-controller icon indicating copy to clipboard operation
kustomize-controller copied to clipboard

WIP: Prebuild Stage Feature

Open oliverbaehler opened this issue 3 years ago • 6 comments

I tried implementing a solution for issue #414 Since this is my first contribution in go i am not quiet sure how good it is. But i tested it and it works. But hard to tell.

I created this PR as Draft, so we can discuss over the feature. If the feature is seen as plausible, I will commit further changes (tests, etc) which comply with the contributions guidelines.

I didn't make them yet, because I don't want to waste time for something that could be rejected.

Signed-off-by: Oliver Bähler [email protected]

oliverbaehler avatar Sep 17 '21 10:09 oliverbaehler

I have tested your PR (https://github.com/fluxcd/kustomize-controller/pull/430) with my own stuff and it's working pretty well. I hope it will be merged soon.

vcariven avatar Sep 22 '21 06:09 vcariven

@stefanprodan What is your opinion about the clarified scope of the preBuild feature (https://github.com/fluxcd/kustomize-controller/issues/414#issuecomment-920729681), that @oliverbaehler implemented in this PR ? Do you think we can expect it to be merged once the reviews are passed or does it break the spirit of the kustomize-controller ? Regards,

vcariven avatar Sep 23 '21 12:09 vcariven

I guess this won't be implemented

oliverbaehler avatar Nov 29 '21 13:11 oliverbaehler

Just going through this, any reason why this wasn't picked? It will simplify a lot of kustomization files with paths made dynamic.

adusumillipraveen avatar Jul 05 '23 10:07 adusumillipraveen