ImageUpdateAutomation shows commit success but no commits in git repo

[rgaoistheone]

Hi guys, when I tried ImageUpdateAutomation earlier today I found that there is no commits in my repo while the ImageUpdateAutomation status tells me that push succeed.

  Normal  info    2m24s (x98 over 97m)  image-automation-controller  (combined from similar events): committed and pushed change 0b7b9a2f02375e47a5f4ff6ff563517cb35f4eb0 to master

[kingdonb]

Is there any way that you can share more information about your setup so that we can reproduce this issue?

We're having a discussion in Bug Scrub about a rewrite of source controller and we hope to have that landing soon.

There are some places we've identified in the code where messages may be emitted even though things have not happened yet. In the new refactored version, we are much stricter about when we emit messages and it is likely this will be fixed.

However having not seen a concrete repro, I can't say that for sure. Can you provide more information please? If there's any way to provide enough information so that we can reproduce it, that would be very helpful.

[rgaoistheone]

Is there any way that you can share more information about your setup so that we can reproduce this issue?

We're having a discussion in Bug Scrub about a rewrite of source controller and we hope to have that landing soon.

There are some places we've identified in the code where messages may be emitted even though things have not happened yet. In the new refactored version, we are much stricter about when we emit messages and it is likely this will be fixed.

However having not seen a concrete repro, I can't say that for sure. Can you provide more information please? If there's any way to provide enough information so that we can reproduce it, that would be very helpful.

Hi @kingdonb , Thanks for kind reply, turns out this issue was caused by not specifying the right email address since our repo has rules for that. But it really took me quite some time to troubleshoot , there is only success logs everywhere 😂. So maybe this case is not what you expect but for beginners like me would really appreciate " Trace " log if possible . Oh and feel free to close this issue anytime.

[kingdonb]

I'd like to keep the issue open, but re-title it as:

"Git push failures are not logged when repo validation fails a commit"

If you can give a reference to the docs for whatever feature you're using to validate commits, so that we can be sure it can be reproduced and ultimately gets resolved 👍 we should be able to make this emit a clear error message as an event and log when something goes wrong.