helm-operator icon indicating copy to clipboard operation
helm-operator copied to clipboard

valuesFromFile to create key's value sourced from file content

Open cdenneen opened this issue 4 years ago • 2 comments

valuesFromFile:
  chartFileRef:
    myScript: path/to/file.js
  externalSourceRef:
    defaultScript: https://raw.githubusercontent.com/cdenneen/example/master/script.js

result in equivalent of:

helm install --set-file key=path/to/file.js

myScript: |
  const { events, Job } = require("brigadier")
  function run(e, project) {
    console.log("this is my script")
  }
  events.on("run", run)
defaultScript: |
  const { events, Job } = require("brigadier")
  function run(e, project) {
    console.log("hello default script")
  }
  events.on("run", run)

cdenneen avatar Aug 02 '19 18:08 cdenneen

I see, the aim is to put a file content into a subkey of values, rather than expecting a whole values file. Seems reasonable to me.

I think this can be done backward-compatibly by adding a valuesKey field to externalSourceRef, secretKeyRef, chartFileRef, configMapKeyRef (in the cases of secretKeyRef and configMapKeyRef, there is already a field key, so the new field cannot have that name).

squaremo avatar Aug 05 '19 11:08 squaremo

So for backward-compatibly, this would look like this if I understand properly :

valuesFromFile:
  chartFileRef:
    valuesKey: myscript
    path: path/to/file.js
  externalSourceRef:
    valuesKey: defaultScript
    url: https://raw.githubusercontent.com/cdenneen/example/master/script.js

If so, then I can have a look, this is something I'd like to have available to only store externally the values and not the whole yaml structure key: value

lvincel avatar May 09 '20 15:05 lvincel

Sorry if your issue remains unresolved. The Helm Operator is in maintenance mode, we recommend everybody upgrades to Flux v2 and Helm Controller.

A new release of Helm Operator is out this week, 1.4.4.

We will continue to support Helm Operator in maintenance mode for an indefinite period of time, and eventually archive this repository.

Please be aware that Flux v2 has a vibrant and active developer community who are actively working through minor releases and delivering new features on the way to General Availability for Flux v2.

In the mean time, this repo will still be monitored, but support is basically limited to migration issues only. I will have to close many issues today without reading them all in detail because of time constraints. If your issue is very important, you are welcome to reopen it, but due to staleness of all issues at this point a new report is more likely to be in order. Please open another issue if you have unresolved problems that prevent your migration in the appropriate Flux v2 repo.

Helm Operator releases will continue as possible for a limited time, as a courtesy for those who still cannot migrate yet, but these are strongly not recommended for ongoing production use as our strict adherence to semver backward compatibility guarantees limit many dependencies and we can only upgrade them so far without breaking compatibility. So there are likely known CVEs that cannot be resolved.

We recommend upgrading to Flux v2 which is actively maintained ASAP.

I am going to go ahead and close every issue at once today, Thanks for participating in Helm Operator and Flux! 💚 💙

kingdonb avatar Sep 02 '22 19:09 kingdonb