helm-operator icon indicating copy to clipboard operation
helm-operator copied to clipboard

Add info metric for release labels

Open carlpett opened this issue 4 years ago • 5 comments

This PR adds informational metrics about the HelmRelease object, for example:

flux_helm_operator_release_labels{label_foo="florp",label_hej="hopp",release_name="my-release",target_namespace="some-ns"} 1
flux_helm_operator_release_labels{label_baz="qux",label_foo="bar",release_name="another-release",target_namespace="default"} 1

This goes along the lines of the metrics exposed by kube-state-metrics, and is useful to join in with the conditions metric for alerting (eg a team label in our case).

I'm not quite sure I like the wiring-up bits in the operator itself, please have an extra look at what you think there.

Signed-off-by: Calle Pettersson [email protected]

carlpett avatar Jun 05 '20 12:06 carlpett

I can't request reviewers? cc @hiddeco @stefanprodan I guess?

carlpett avatar Jun 05 '20 12:06 carlpett

Marking as "ready for review" since maybe that was preventing notifications? Still very open to feedback that something ought to be done differently

carlpett avatar Jun 08 '20 17:06 carlpett

ping @hiddeco @stefanprodan @2opremio @squaremo

carlpett avatar Jun 22 '20 09:06 carlpett

This is a very useful metric, it can be used to label the slack channel do you want to send a notification if the release fails. I hope it gets merged soon

ercpereda avatar Aug 05 '20 19:08 ercpereda

Hi, is there any plan to review and merge this PR ? We are also using labels on Kubernetes resources to route alerts to the right teams.

Thanks !

AdrienKuhn avatar Aug 18 '20 21:08 AdrienKuhn

Thanks for contributing here! We are not going to make any changes like this here, Flux v1 and Helm Operator are in maintenance mode

You are welcome to reopen this discussion on fluxcd/flux2 if there's something to address in the current series!

Closing, stale.

kingdonb avatar Sep 02 '22 18:09 kingdonb